kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Seth,

I'm not too sure about this.  I just tested it on linux and the results 
weren't all that good.  Having the columns be too narrow isn't much of 
an improvement over having them too wide.  When ever I have to hard code 
a control width, I can't help but feel that I'm doing something wrong. 
For the most part, wx resizes controls pretty well.  I know there are 
some controls that don't work well but I wonder if this is the best 
solution.  I probably should have had the original developer us wxGrid 
instead.  It would have been a more logical choice in this case.  We are 
just going to have to live with this for v5 until someone can rewrite it 
during v6 development.  I'm not completely opposed to the change but I 
really would like to find a better solution if possible.

Cheers,

Wayne

On 02/14/2018 04:45 PM, Seth Hillbrand wrote:
> ​Currently in the BOM editor​ (also called "Edit Symbol Fields" or 
> "Symbol Table"), when you first open it, the columns are auto-sized.  
> With multiple references, this means that initially the reference column 
> takes up the whole window.
>
> I realized that I had just fallen into the habit of unchecking and 
> immediately checking the "Show" checkbox for all my columns so that I 
> could see them.  This resets the column width to 150 (hard-coded), which 
> seems sensible on my monitor.
>
> The attached patch moves the column width at the outset to the default 
> value, preventing massive strings from taking over the column.  It also 
> abstracts the default width to a getter method with the intention of 
> having the variable be configurable come v6.
>
> If someone with a hi-dpi monitor could check whether the hard coded 
> value is wonky for them, I'd greatly appreciate it!
>
> -S
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp