← Back to team overview

kicad-developers team mailing list archive

Re: Pushed change

 

On 2018-03-12 03:19 PM, Jeff Young wrote:
I just pushed a change which removes a bunch of unnecessary boilerplate.

But it occurs to me that maybe it’s necessary with pickier compilers?  Anyway, if someone could try it on Windows and/or Unix that would be great.
Oops. Something broke. I'm using g++ (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 under Linux Mint 18.3


/home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp: In member function ‘void CVPCB_MAINFRAME::UpdateTitle()’: /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43: error: operands to ?: have different types ‘const wxChar* {aka const wchar_t*}’ and ‘const wxString’ fn.IsFileWritable() ? wxEmptyString : _( " [Read Only]" ) );
                                           ^
/home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43: note: and each type can be converted to the other cvpcb/CMakeFiles/cvpcb_kiface.dir/build.make:326: recipe for target 'cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o' failed
make[2]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o] Error 1
CMakeFiles/Makefile2:817: recipe for target 'cvpcb/CMakeFiles/cvpcb_kiface.dir/all' failed
make[1]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/all] Error 2
Makefile:149: recipe for target 'all' failed
make: *** [all] Error 2


--
Cheers!

Kevin.

http://www.ve3syb.ca/                | "Nerds make the shiny things that
https://www.patreon.html/KevinCozens | distract the mouth-breathers, and
                                     | that's why we're powerful"
Owner of Elecraft K2 #2172           |
#include <disclaimer/favourite>      |             --Chris Hardwick


Follow ups

References