kicad-developers team mailing list archive

[Simon Wells <swel024@xxxxxxxxx>]

do they really need to if its an “internal” cmake macro

> On 31/03/2018, at 10:24 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> 
> I'm using 3.10 so that's why I haven't seen this yet.  I guess we are
> going to have to fix this.  It's would be nice if the cmake folks would
> have at least provided a substitution and a warning rather than break
> everybody's configuration who uses CHECK_SYMBOL_EXISTS.
> 
> On 3/30/2018 5:15 PM, Seth Hillbrand wrote:
>> Hi Adam-
>> 
>> You will need to downgrade to CMake 3.10 or lower.  In 3.11, they
>> revised the internals of CheckSymbolExists.
>> 
>> Our macro depends on the internal CMake macro _CHECK_SYMBOL_EXISTS (note
>> the underscore at the beginning).  In 3.11, they replaced it with
>> __CHECK_SYMBOL_EXISTS_IMPL.
>> 
>> -S
>> 
>> 2018-03-30 13:24 GMT-07:00 Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>> <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>:
>> 
>>    Hey Adam,
>> 
>>    According to the latest cmake (3.11) docs[1], CheckCXXSymbolExists.cmake
>>    still contains a CHECK_SYMBOL_EXISTS command.  This has been around for
>>    a really long time, I'm not sure why you would be having issues with
>>    this now unless you have a broken cmake install.
>> 
>>    Wayne
>> 
>>    On 3/30/2018 3:56 PM, Adam Wolf wrote:
>>> Hi folks!
>>> 
>>> Normally I wouldn't ask this question on the list, but it's at or past
>>> crunch time on the new macOS packaging, so please forgive me.
>>> 
>>> I have a macOS 10.11 system I use for KiCad packaging sometimes, and
>>> I'm running some tests on it.  It has cmake 3.11.0 on it.
>>> 
>>> 8 days ago, I was able to build kicad master on it.  Today, I can't
>>> configure on it.  I get
>>> 
>>> CMake Error at CMakeModules/CheckCXXSymbolExists.cmake:41
>>> (_CHECK_SYMBOL_EXISTS):
>>>    Unknown CMake command "_CHECK_SYMBOL_EXISTS".
>>> Call Stack (most recent call first):
>>>    CMakeModules/PerformFeatureChecks.cmake:84 (check_cxx_symbol_exists)
>>>    CMakeLists.txt:166 (perform_feature_checks)
>>> 
>>> This machine is just used for KiCad, and this error doesn't really
>>> make sense to me.  It very well could be with the scripts I'm using
>>> for testing, but I'm asking in case anyone has any ideas or has seen
>>> something similar.
>>> 
>>> Adam Wolf
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>    <https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>>
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>    <https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>>
>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>    <https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>>
>>> 
>> 
>> 
>>    _______________________________________________
>>    Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>    <https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>>
>>    Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>    Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>    <https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>>
>>    More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>    <https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>>
>> 
>> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>