kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

I think the reason is that KIPRJMOD is not editable.  Still, it would be better to show it in the dialog and just make it read-only (as then the user would know it existed without opening the help window).  Feel free to log a bug for that (just set its milestone to 6.0).

I’ll merge your patch.  Thanks for your contribution!

Cheers,
Jeff.

> On 6 Apr 2018, at 14:05, kristoffer Ödmark <kristofferodmark90@xxxxxxxxx> wrote:
> 
> Turns out the redundant code was not very redundant. There would have to be some more refactoring of the code to
> get this all using the NormalizePath command in common/env_paths.cpp
> 
> I am also uncertain, since I dont understand the codebase good enough, to why Pgm.GetLocalEnvVars does not
> include the env var to KIPRJMOD, I guess there is a reason?
> 
> 
> On 2018-04-06 13:05, Jeff Young wrote:
>> Patch looks good to me, although I’d rather see the redundant code removed.
>> 
>> 
>>> On 6 Apr 2018, at 11:30, kristoffer Ödmark <kristofferodmark90@xxxxxxxxx> wrote:
>>> 
>>> <0001-Footprint-Wizard-now-also-handles-custom-Env-paths.patch>
> 
> <0001-Footprint-Wizard-now-also-handles-custom-Env-paths.patch>