kicad-developers team mailing list archive

[Andrzej Wolski <awolski.kicad@xxxxxxxxx>]

From 348f5456d427e22c16577fbfe3712052249e9aa2 Mon Sep 17 00:00:00 2001
From: Andrzej Wolski <awolski.kicad@xxxxxxxxx>
Date: Sun, 17 Jun 2018 14:29:26 +0200
Subject: [PATCH 1/2] Do not allow setting zero Y size for oval holes

---
 pcbnew/dialogs/dialog_pad_properties.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pcbnew/dialogs/dialog_pad_properties.cpp b/pcbnew/dialogs/dialog_pad_properties.cpp
index 646546da8..cfc1b05a2 100644
--- a/pcbnew/dialogs/dialog_pad_properties.cpp
+++ b/pcbnew/dialogs/dialog_pad_properties.cpp
@@ -1196,7 +1196,8 @@ bool DIALOG_PAD_PROPERTIES::padValuesOK()
     {
     case PAD_ATTRIB_HOLE_NOT_PLATED:   // Not plated, but through hole, a hole is expected
     case PAD_ATTRIB_STANDARD :         // Pad through hole, a hole is also expected
-        if( m_dummyPad->GetDrillSize().x <= 0 )
+        if( m_dummyPad->GetDrillSize().x <= 0 ||
+            ( m_dummyPad->GetDrillSize().y <= 0 && m_dummyPad->GetDrillShape() == PAD_DRILL_SHAPE_OBLONG ) )
             error_msgs.Add( _( "Error: Through hole pad: drill diameter set to 0" ) );
         break;
 
-- 
2.16.2