kicad-developers team mailing list archive

[Seth Hillbrand <seth.hillbrand@xxxxxxxxx>]

​Hi Wayne-

I would view this patch more as defensive coding than trying to fix others'
errors.  The alternatives are to refuse to parse the file or (as we
currently do) parse as written and encounter errors in display and
routing.  JP's approach provides a clear and predictable response to a
modified file.

-Seth​


Am Mo., 25. Juni 2018 um 06:16 Uhr schrieb Wayne Stambaugh <
stambaughw@xxxxxxxxx>:

> On 6/25/2018 8:12 AM, jp charras wrote:
> > Le 24/06/2018 à 21:52, Wayne Stambaugh a écrit :
> >> Are we planning on fixing this for rc3?  If so, what is required.  I'm
> fine with waiting a day or
> >> two to tag rc3.
> >>
> >
> > Attached a possible fix.
> >
> > The board test file shows really broken layer set in a few pads:
> > - no layers for some pads (the layers section is empty).
> > This make no sense for me.
> >
> > After tests, It is not possible to create this empty layer set from
> Pcbnew (even with old 2013
> > stable version).
> >
> > My opinion is the board (or the footprints) was modified by hand (or by
> a script).
>
> If this is the case, then I'm not thrilled about applying this patch
> even if it does solve the problem.  We should not be modifying KiCad to
> fix other people's coding errors.
>
> >
> > This patch is short and fixes silently this kind of issues.
> > (I am not sure it is worth to try a better fix, because this issue
> cannot happens when editing a
> > board from pcbnew)
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>