← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH v2] Rewrite test for valid characters in names

 

Hi Seth,

On 06/28/2018 07:56 PM, Seth Hillbrand wrote:

> ​Understood.   What's the impact of the array assignment now?  ​

MSVC refuses to compile it.

It seems to be an artefact from a gcc extension that allows the result
of a ternary to be an lvalue if both branches are, but I don't think
that is part of the extension specification, just an implementation
detail of their type resolver.

Also, it is way larger code and slower, not that this matters.

   Simon


Follow ups

References