kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #36360
Re: [PATCH v2] Rewrite test for valid characters in names
That makes sense, thanks. Can you do a git format-patch for this change?
We'll look at moving the higher loops to std::replace_copy_if during v5.1
-S
Am Do., 28. Juni 2018 um 11:34 Uhr schrieb Simon Richter <
Simon.Richter@xxxxxxxxxx>:
> Hi Seth,
>
> On 06/28/2018 07:56 PM, Seth Hillbrand wrote:
>
> > Understood. What's the impact of the array assignment now?
>
> MSVC refuses to compile it.
>
> It seems to be an artefact from a gcc extension that allows the result
> of a ternary to be an lvalue if both branches are, but I don't think
> that is part of the extension specification, just an implementation
> detail of their type resolver.
>
> Also, it is way larger code and slower, not that this matters.
>
> Simon
>
References