← Back to team overview

kicad-developers team mailing list archive

Re: Patch to draw bitmaps in GAL canvases

 

On 30/07/18 11:14, jp charras wrote:
> Le 30/07/2018 à 00:29, Tomasz Wlostowski a écrit :
>> On 27/07/18 15:31, jp charras wrote:
>>> Le 27/07/2018 à 15:20, Tomasz Wlostowski a écrit :
>>>
>> Hi again,
>>
>> I've optimized the OpenGL bitmap drawing code (now it caches the bitmaps
>> and uses textures to draw them). Both mine and your patch are now in the
>> master branch.
>>
>> Thanks!
>> Tom
>>
> 
> 
> Thanks.
> 
> I have a strange behavior on OpenGL.
> 
> Some bitmaps (not all) are incorrectly drawn (both on Windows and Linux).
> I discovered bitmaps that are correctly drawn have a width multiple of 4.
> 
> Attached a bitmap incorrectly drawn by OpenGL, and a patch that fixes this issue on my Windows install.
> 
> Have you encountered this issue (I had a look into glTexImage2D doc. glTexImage2D can have some
> constraints, but I did not see this constraint)
> 

Hi JP,

Good catch, go ahead and merge it!

Cheers,
Tom


Follow ups

References