kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

I wonder why the python scripting devs didn't use all uppercase like the 
C++ source?  I guess it makes sense to leave it as is for the sake of 
consistency.

On 08/31/2018 06:15 PM, Andrew Lutsenko wrote:
> @Wayne,
>
> Quick grep suggested that _List is the current convention:
>
> $ egrep -ho '[a-zA-Z_]+_List' -R ./pcbnew | sort -u
> BOARD_ITEM_List
> delete_BOARD_ITEM_List
> delete_MODULE_List
> delete_PAD_List
> delete_TRACK_List
> MODULE_List
> new_BOARD_ITEM_List
> new_MODULE_List
> new_PAD_List
> new_TRACK_List
> PAD_List
> TRACK_List
>
> Search for _LIST returns more types but they seem mostly autogenerated 
> swig types like _swigc__xxxx_LIST or _wrap_xxxx_LIST
>
> @Nick,
>
> Great idea, I didn't know we had python tests. I'll add one.
>
> Best,
> Andrew
>
> On Fri, Aug 31, 2018 at 7:48 AM Nick Østergaard <oe.nick@xxxxxxxxx 
> <mailto:oe.nick@xxxxxxxxx>> wrote:
>
>     I cant view the patch via my phone right now, but please add a
>     simple unittest in the qa folder as well.
>
>     fre. 31. aug. 2018 14.56 skrev Wayne Stambaugh <stambaughw@xxxxxxxxx
>     <mailto:stambaughw@xxxxxxxxx>>:
>
>         Andrew,
>
>         I looked at this patch an it looks fine to me.  I fine with
>         exposing the
>         3D model properties in the Python scripting.  Is there a reason
>         why you
>         use MODULE_3D_SETTINGS_List instead of MODULE_3D_SETTINGS_LIST
>         for the
>         template name?  Typically we use the latter.  Can anyone think
>         of a good
>         reason not to exposed the 3D model properties in the python
>         scripting?
>         If not, I will merge this patch.
>
>         Cheers,
>
>         Wayne
>
>         On 8/31/2018 6:42 AM, Andrew Lutsenko wrote:
>          > Hi all,
>          >
>          > This is a fix for https://bugs.launchpad.net/kicad/+bug/1758858
>          >
>          > Regards,
>          > Andrew
>          >
>          >
>          >
>          > _______________________________________________
>          > Mailing list: https://launchpad.net/~kicad-developers
>         <https://launchpad.net/%7Ekicad-developers>
>          > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>          > Unsubscribe : https://launchpad.net/~kicad-developers
>         <https://launchpad.net/%7Ekicad-developers>
>          > More help   : https://help.launchpad.net/ListHelp
>          >
>
>         _______________________________________________
>         Mailing list: https://launchpad.net/~kicad-developers
>         <https://launchpad.net/%7Ekicad-developers>
>         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         Unsubscribe : https://launchpad.net/~kicad-developers
>         <https://launchpad.net/%7Ekicad-developers>
>         More help   : https://help.launchpad.net/ListHelp
>
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/%7Ekicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/%7Ekicad-developers>
>     More help   : https://help.launchpad.net/ListHelp