← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Documentation: UI policy update about dialogs

 

Hi Nabeel,

The documentation should read "wxFormbuilder 3.8.0 or later" so please
revise your patch.  Expecting developers to use a given version in not
reasonable due to platform differences.  This will always be an issue so
I'm fine with using later versions of wxFormbuilder.  Building
wxFormbuilder from source has been fairly trivial so I don't think it's
a stretch for KiCad developers to build from source if needed.

Cheers,

Wayne

On 12/1/2018 8:48 AM, Nabeel Ahmad wrote:
> Hello,
> 
>     Le 01/12/2018 à 13:23, Nabeel Ahmad a écrit : > Hello, > > Some
>     wxFormBuilder projects files in the source code are incompatible >
>     with the > wxFormBuilder version currently recommended in the
>     documentation [1]. One > example of such a file is [2]. This file
>     has been created with wxFormBuilder > v3.8.1, as evidenced by the
>     version date in the .cpp file generated by > it [3].
>     What is the problem? Files are the same (not considering the FB
>     build version date).
> 
> The only issue is that the project file [1] fails to open with
> wxFB3.5-RC1 [2]
> which is recommended in the documentation [3]. wxFB complains about
> about file
> version [4]. The file opens without any problem with wxFB version 3.8.
> 
> [1]: https://git.launchpad.net/kicad/tree/pcb_calculator/dialogs/pcb_calculator_frame_base.fbp
> [2]: https://github.com/marekr/wxFormBuilder/tree/wxFB3.5-RC1
> [3]: http://docs.kicad-pcb.org/doxygen/md_Documentation_development_ui-policy.html#dialogs
> [4]: See attached image
> 
> Regards,
> Nabeel Ahmad
> 
> ------------------------------------------------------------------------
> *From:* Nabeel Ahmad <nabeel.ahmad1@xxxxxxxxxxx>
> *Sent:* Saturday, December 1, 2018 5:23 PM
> *To:* kicad-developers@xxxxxxxxxxxxxxxxxxx
> *Subject:* Re: [PATCH] Documentation: UI policy update about dialogs
>  
> Hello,
> 
> Some wxFormBuilder projects files in the source code are incompatible
> with the
> wxFormBuilder version currently recommended in the documentation [1]. One
> example of such a file is [2]. This file has been created with wxFormBuilder
> v3.8.1, as evidenced by the version date in the .cpp file generated by
> it [3].
> The documentation needs to be updated in order to remove misleading
> information
> about wxFormBuilder version.
> 
> [1]: http://docs.kicad-pcb.org/doxygen/md_Documentation_development_ui-policy.html#dialogs
> [2]: https://git.launchpad.net/kicad/tree/pcb_calculator/dialogs/pcb_calculator_frame_base.fbp
> [3]: https://git.launchpad.net/kicad/tree/pcb_calculator/dialogs/pcb_calculator_frame_base.cpp
> 
> Regards,
> Nabeel Ahmad
> 
> ------------------------------------------------------------------------
> *From:* Nabeel Ahmad <nabeel.ahmad1@xxxxxxxxxxx>
> *Sent:* Wednesday, November 28, 2018 8:24 PM
> *To:* kicad-developers@xxxxxxxxxxxxxxxxxxx
> *Subject:* [PATCH] Documentation: UI policy update about dialogs
>  
> Hello,
> 
> This patch updates out-of-date documentation about the use of wxFormBuilder.
> * Changes the standard wxFormBuilder version to 3.8.0 as discussed in [1].
> * Opens the option of creating new dialogs by hand as discussed in [2].
> 
> [1]: https://lists.launchpad.net/kicad-developers/msg36968.html
> [2]: https://lists.launchpad.net/kicad-developers/msg37324.html
> 
> Regards,
> Nabeel Ahmad
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


References