← Back to team overview

kicad-developers team mailing list archive

Re: Polygon build broken

 

Seth,

You're probably already aware, but just in case: `git blame file_path` will
tell you the commit hash, person, & date for every line, to see who landed
the problem line, and `git bisect` (
https://stackoverflow.com/a/37306623/4561887) will help you binary search
between a known good commit and a known bad commit to find out which commit
introduced the bug.

Gabe


Electric RC Aircraft Guy, LLC
www.ElectricRCAircraftGuy.com <http://www.electricrcaircraftguy.com/>

*Check out my Computa Pranksta
<https://www.amazon.com/Computa-Pranksta-Keyboard-Device-50-Settings/dp/B06ZYZ2GTB/ref=as_li_ss_tl?ie=UTF8&linkCode=ll1&tag=wwwel-20&linkId=9658f0731a67191094d079bb8111fc36>
USB
device sold on Amazon!*



On Wed, Dec 12, 2018 at 10:23 AM Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:

> Hi All-
>
> A recent commit broke the polygon build
>
> Here's the error:
>
> /home/seth/code/kicad/kicad-launchpad/polygon/PolyLine.cpp: In member
> function ‘bool CPolyLine::TestPointInside(int, int)’:
> /home/seth/code/kicad/kicad-launchpad/polygon/PolyLine.cpp:934:37:
> error: cannot convert ‘CPOLYGONS_LIST’ to ‘const wxPoint*’
>           if( TestPointInsidePolygon( m_CornersList, istart, iend, px, py
> ) )
>                                       ^~~~~~~~~~~~~
> In file included from
> /home/seth/code/kicad/kicad-launchpad/polygon/PolyLine.cpp:46:
> /home/seth/code/kicad/kicad-launchpad/polygon/./polygon_test_point_inside.h:63:45:
>
> note:   initializing argument 1 of ‘bool TestPointInsidePolygon(const
> wxPoint*, int, const wxPoint&)’
>   bool TestPointInsidePolygon( const wxPoint* aPolysList,
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References