kicad-developers team mailing list archive

[Maciej Suminski <maciej.suminski@xxxxxxx>]

Hi,

On 12/29/18 12:45 AM, Mark Roszko wrote:
> The error is from this patch:
> 
> https://github.com/KiCad/kicad-source-mirror/commit/24f9bfa13b54267417ec971dca6cac005ce8b857

Apologies for the mistake, obviously it was not an intentional change. I
see that John Beard has already fixed the problem, many thanks!

> May I suggest whoever updates it, also adds a comment about intentionally
> using wxFileConfig?

Good idea, I have added a relevant comment.

> Is there even a point in typecasting the pointer from GetNewConfig to
> wxConfigBase instead of just returning wxFileConfig?

I imagine this is to prevent calling wxFileConfig specific functions, so
the returned variable is treated as a generic configuration.

Cheers,
Orson

> 
> On Fri, Dec 28, 2018 at 6:21 PM Wayne Stambaugh <stambaughw@xxxxxxxxx>
> wrote:
> 
>> Someone has completely broken configuration settings on windows.  Most
>> likely caused by using wxConfig instead of wxFileConfig which used to be
>> the default until recently.  Who ever made this change, please fix it.
>> We do not use the windows registry to save KiCad configuration settings.
>>  This was a decision made a long time ago which I have zero interest in
>> changing.
>>
>> Cheers,
>>
>> Wayne
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature