kicad-developers team mailing list archive

[Jon Evans <jon@xxxxxxxxxxxxx>]

Hi Michal,

First of all, I unfortunately have not yet actually tried out your branch
so I can't comment on the performance/functionality of your code.

There was already a launchpad issue tracking this feature request here:
https://bugs.launchpad.net/kicad/+bug/1678345
I had been working on it a long time ago, but switched to some other
features and haven't gotten back to it.

I would be fine with handing over responsibility for this feature to you if
you'd like, but I think that your proposed change as-is doesn't go far
enough.
We should be developing a color theme system that works across all the
applications, not just eeschema (in my opinion).

Apart from that, from a quick review of your code I have some questions:

- Why store all color schemes in a single file instead of one file per
scheme? The latter is what I had planned, and seems easier to share between
users.
- Is there a way to revert to the default (hard-coded) colors?  I didn't
see one, but again I haven't run the code
- "ChangeColorShemaInTempFile" -> I think "Shema" should be "Scheme" right?

Finally, for acceptance you would need to provide your changes as patch
files (using `git format-patch`) rather than a github branch.

Best,
Jon

On Thu, Jan 10, 2019 at 10:15 AM Michal <woocom@xxxxx> wrote:

> Eeschema: Adding a color scheme selection option
>
> NEW: Adds support in eeschema to change colors, choosing from the list of
> color schemes.
> The user can create his own list of color schemes. The color schemes are
> saved in the configuration file "eeschema.colors".
>
> Link to my branch:
> https://github.com/michallukowski/kicad-source-mirror/tree/color_scheme
>
> Regards
> Michal
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>