kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #39060
Re: [PATCH 1/7] Clear comp highlighting before highlight new one.
Information from last build:
Application: eeschema
Version: (6.0.0-rc1-dev-1542-gf9f87b3ff), debug build
Libraries:
wxWidgets 3.0.4
libcurl/7.63.0 OpenSSL/1.1.1a zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2
(+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.35.1
Platform: Linux 4.20.0-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
Boost: 1.68.0
OpenCASCADE Community Edition: 6.9.1
Curl: 7.63.0
Compiler: GCC 8.2.1 with C++ ABI 1013
Build settings:
USE_WX_GRAPHICS_CONTEXT=OFF
USE_WX_OVERLAY=OFF
KICAD_SCRIPTING=ON
KICAD_SCRIPTING_MODULES=ON
KICAD_SCRIPTING_PYTHON3=OFF
KICAD_SCRIPTING_WXPYTHON=ON
KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
KICAD_SCRIPTING_ACTION_MENU=ON
BUILD_GITHUB_PLUGIN=ON
KICAD_USE_OCE=ON
KICAD_USE_OCC=OFF
KICAD_SPICE=ON
ср, 16 янв. 2019 г. в 16:58, Wayne Stambaugh <stambaughw@xxxxxxxxx>:
> Konstantin,
>
> What platform did you use to test your changes? If it was linux, are
> you using gtk2 or gtk3? Would some of our other devs please test this
> patch set. wxGrid tends to have it's own set of platform dependent
> quirks so I would like to avoid breaking anything before merging these
> changes.
>
> Cheers,
>
> Wayne
>
> On 1/16/2019 8:16 AM, Baranovskiy Konstantin wrote:
> > On clicking a reference cell in the field editor of Eeschema a
> > corresponding component is highlighted in Eeschema. But previously
> > highlighted components are staying highlighted.
> >
> > With current patch all highlightings are cleared before highlighting
> > selected component.
> > ---
> > eeschema/dialogs/dialog_fields_editor_global.cpp | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/eeschema/dialogs/dialog_fields_editor_global.cpp
> b/eeschema/dialogs/dialog_fields_editor_global.cpp
> > index d2616ea95..603ebf649 100644
> > --- a/eeschema/dialogs/dialog_fields_editor_global.cpp
> > +++ b/eeschema/dialogs/dialog_fields_editor_global.cpp
> > @@ -979,6 +979,7 @@ void DIALOG_FIELDS_EDITOR_GLOBAL::OnTableCellClick(
> wxGridEvent& event )
> > {
> > // Clear highligted symbols, if any
> > m_parent->GetCanvas()->GetView()->HighlightItem( nullptr,
> nullptr );
> > + m_parent->GetCanvas()->Refresh();
> >
> > m_dataModel->ExpandCollapseRow( event.GetRow() );
> > std::vector<SCH_REFERENCE> refs =
> m_dataModel->GetRowReferences( event.GetRow() );
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References