kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Konstantin,

What platform did you use to test your changes?  If it was linux, are
you using gtk2 or gtk3?  Would some of our other devs please test this
patch set.  wxGrid tends to have it's own set of platform dependent
quirks so I would like to avoid breaking anything before merging these
changes.

Cheers,

Wayne

On 1/16/2019 8:16 AM, Baranovskiy Konstantin wrote:
> On clicking a reference cell in the field editor of Eeschema a
> corresponding component is highlighted in Eeschema. But previously
> highlighted components are staying highlighted.
> 
> With current patch all highlightings are cleared before highlighting
> selected component.
> ---
>  eeschema/dialogs/dialog_fields_editor_global.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/eeschema/dialogs/dialog_fields_editor_global.cpp b/eeschema/dialogs/dialog_fields_editor_global.cpp
> index d2616ea95..603ebf649 100644
> --- a/eeschema/dialogs/dialog_fields_editor_global.cpp
> +++ b/eeschema/dialogs/dialog_fields_editor_global.cpp
> @@ -979,6 +979,7 @@ void DIALOG_FIELDS_EDITOR_GLOBAL::OnTableCellClick( wxGridEvent& event )
>      {
>          // Clear highligted symbols, if any
>          m_parent->GetCanvas()->GetView()->HighlightItem( nullptr, nullptr );
> +        m_parent->GetCanvas()->Refresh();
>  
>          m_dataModel->ExpandCollapseRow( event.GetRow() );
>          std::vector<SCH_REFERENCE> refs = m_dataModel->GetRowReferences( event.GetRow() );
>