← Back to team overview

kicad-developers team mailing list archive

[PATCH] Fix layout in exit confirm dialog

 

Hi,

Tiny patch to lay the exit confirm dialog out using its own Layout call.

Without this, it was laying out incorrectly in the footprint editor
[1]. Not sure why not in pcbnew, but this seems to work!

Cheers,

John

[1]: https://bugs.launchpad.net/kicad/+bug/1813961
From e5a93bc431319e6fa3dcbcd2efc9845d5d32da77 Mon Sep 17 00:00:00 2001
From: John Beard <john.j.beard@xxxxxxxxx>
Date: Wed, 30 Jan 2019 16:48:09 +0000
Subject: [PATCH] Exit dialog: use Layout on the whole window

Prevents mislaignment in footpritn editor on close with unsaved
changes.

Fixes: lp:1813961
* https://bugs.launchpad.net/kicad/+bug/1813961
---
 common/confirm.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/common/confirm.cpp b/common/confirm.cpp
index 85fe46960..3e5080dd4 100644
--- a/common/confirm.cpp
+++ b/common/confirm.cpp
@@ -167,8 +167,7 @@ public:
         m_sdbSizer1Cancel->SetLabel( aCancelLabel );
         m_sdbSizer1OK->SetDefault();
 
-        m_sdbSizer1->Layout();
-        m_buttonSizer->Layout();
+        Layout();
 
         FinishDialogSettings();
     };
-- 
2.20.1


Follow ups