← Back to team overview

kicad-developers team mailing list archive

Re: When are Patches pulled in ?

 

Hi Seth,

ah, okay, i was not supposed to change the status. It seemd naturally for me to set it to „Fix Committed“ after i thought that i‘m done with it.
PEBCAK as usual 😊 

Thank you for the help! 

-Daniel

Von: Seth Hillbrand
Gesendet: Dienstag, 12. Februar 2019 04:05
An: Daniel Walter
Cc: kicad-developers@xxxxxxxxxxxxxxxxxxx; Kicad-developers
Betreff: Re: [Kicad-developers] When are Patches pulled in ?

Am 2019-02-11 20:13, schrieb Daniel Walter:
> Hi,
> 
> i have noticed that my Patches for #1745607 never made it into release
> altough the Status of the bug is „Fix released“. I am a bit
> confused now because I understood that „Fix released“ means „the
> patch has been merged into the main tree“. Is that not correct ?
> 
> Please do not get me wrong, i do not want to complain about this or
> need it for my ego 😊 . I am just trying to understand how and when
> patches go into release, so if someone could shed light that would be
> nice. Thanks!
> 
> --Daniel

Hi Daniel-

Looking at that briefly, it appears that you set the status to "Fix 
Committed".  This probably caused it to drop of folks' radars.  
Something that is in that status means that the patch has already been 
pushed to the repository (but hasn't been released in one of the 
releases).

I've reset the status to Triaged and set a milestone so that we add this 
during the v6 cycle.  We are already in a string freeze for our 
translators for version 5.1, so we won't be able to push it until the 
development opens for 6.

Sorry for the confusion--hopefully we'll have a better bug system in the 
not-to-distant future that will help prevent this.  And thank you for 
contributing to KiCad!

-S


References