← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 2/3] Fix line endings in pcb_calculator_frame_base.fbp


Hi Simon,

On 3/15/2019 5:43 PM, Simon Richter wrote:
> Hi,
> On 15.03.19 22:01, Simon Richter wrote:
>> No text changes
>>  .../dialogs/pcb_calculator_frame_base.fbp          | 42474 +++++++++----------
>>  1 file changed, 21237 insertions(+), 21237 deletions(-)
> It seems this patch hasn't made it to the list. I just ran dos2unix on
> pcb_calculator/dialogs/pcb_calculator_frame_base.fbp.
>    Simon

I wasn't aware we were converting all wxFormbuilder file line endings to
unix.  I was under the impression that git could handle either without
creating large change sets due to line ending differences.  Is this the
only wxFormbuilder file that has dos line endings or just one you ran
across?  If this the only one, then this is probably not a big deal.  If
there are a bunch of wxFB files that have dos line endings this could be
a very large change set without really changing anything.



Follow ups