kicad-developers team mailing list archive

[Brian <lotharyx@xxxxxxxxx>]

I'm trying to get better at not breaking the KiCad style guidelines, but 
then I see the clang-format tool make suggestions like this:

- static LIB_TEXT* loadText( std::unique_ptr< LIB_PART >& aPart, 
LINE_READER& aReader,
- int aMajorVersion, int aMinorVersion );
- static LIB_RECTANGLE* loadRectangle( std::unique_ptr< LIB_PART >& aPart,
- LINE_READER& aReader );
+ static LIB_TEXT* loadText( std::unique_ptr<LIB_PART>& aPart, 
LINE_READER& aReader,
+ int aMajorVersion, int aMinorVersion );
+ static LIB_RECTANGLE* loadRectangle( std::unique_ptr<LIB_PART>& aPart, 
LINE_READER& aReader );

This doesn't seem right to me, in particular pulling the second line of 
the loadText definition leftward and removing the spaces around template 
parameters.  It makes me reluctant to blindly do a `git clang-format` 
before a commit.

Comments / advice?

Thanks,
-Brian