kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #40410
Re: [PATCH] Crash Reporter
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Thu, 2 May 2019 08:06:35 -0400
-
Autocrypt:
addr=stambaughw@xxxxxxxxx; prefer-encrypt=mutual; keydata= mQGiBEM0hxQRBAC2fNh3YOVLu1d5GZ0SbrTNldGiGnCJPLqzEnqFX9v6jmf33TMt6EmSLkl6 Wtfkoj0nVwKxcYmJkA8DX0QAokBkwNIzhSsBzQvthBLIk/5LnPVVKrEXOcL4mUyH1doKlkaE slgJozNa6Av+oavcvD02o1zJOloBbaHlNlyRt7fKswCgtIFlVjWggVH/15KfWk+Qo5JVPbME AIUBAQyL2OAx0n60AWec2WHnO9buHuG0ibtICgUMkE+2MRmYyKwYRdyVwGoIUemFuOyHp0AJ InX4T+vy2E7vkwODqjtMLfIoRkokW74Fi4nrvjlhOAw/vdq/twLbAmR9MOfPTpR4y7kQy1O2 /n+RkkRvh26vTzfbQmrH7cBJhk6aA/9Uwvu3E4zNJgHVZeS0HyWtmR1eOPPRbnkPgJTToX5O KMKzTJI/FX6kT7cFoCamitHrW3BJP4Dx+cMMsa47EGxqVTdbVJ4LjogsXTXxb+0Fn1u4zBdx x3Cer6O7+hqWy7zvpzeC6nSREjqDKa5CgHtv/GLm5uFPOmsjAsnHj2tlBrQmV2F5bmUgU3Rh bWJhdWdoIDxzdGFtYmF1Z2h3QGdtYWlsLmNvbT6IeAQTEQIAOBYhBOffs6CbblRzBkv33BtR cWlZ+CReBQJbFBS2AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEBtRcWlZ+CReMI8A nRbrLkzp7+c2f0vX7sfg4ICX8LAKAJ9uClo4uJajmZa5zZrL2nKdZlUwIrkCDQRDNIcxEAgA gCru+3/aOC6RCjpvYC72wY+d5SmHphC6yeiV2/mOumyt5MLo/Ps2GznZr11JspqFk5K/Zpvp MMLqqjDZ39+50a2iKRQFJ6NlK+hJWMmj6eJygQrCwYo3Gjc6CqfrqUv+8VSnf/i5sIZmtOVA 4ZjML18MuBvMSsNdVLFJd5HNnYb1iOECpvqdPVh/21LLCEw7MUUGGnHBhCrmk2aJe5hFmcSN g4ldBcXrgMQBwf7aMVoobXBMFDb/IENByXn0llB7Gr2IFMRmNS9/p8s/II1Yl2bTqyX4FSz8 cfn7C9KEz7faZ7wzAcpwHFC/zs3JoAjJ0IEKdNUpIwAlKMzT3CzctwADBQf/cxpG28MKyrqk nNmq/8LQLy+x6FSYXBLjxQz9BiBNYeesDZQ6J5UbL1mjpJzMa5tLZypPYo4bbGyR22hrbyDF K7m6AcVaMIJKl98g4ukMutFfAJyRDaREH5Zl/X1P4u1Z/yaAIy9mKaNbaK1/5djNJ5wCTFen TUgAp9xdc30kGkFDdLJFp5uxDY4P0vaZiZdjUCvDM3Zjv5IzpNOfxVqTUBQNUP/BnnKhkk0p DTD6s3X8S+D0rOtEBQ8K0cwERI/E8EFa8nj0TNw4e2MYGR8wg+SxqJ7z5f0zPY0bO6G9DDFB wYCqzzPWGqdAh9vA5971TAbPERtdFybhkurozp2SfYhJBBgRAgAJBQJDNIcxAhsMAAoJEBtR cWlZ+CResHUAniULLCWiT26ieRTl7N2vS6vBo/DuAJ4m7Ss/gyiW6ybTn1ctDXAUgm2QVQ==
-
In-reply-to:
<6d18b8af-f089-d1ad-eb4a-4ac97f8691ee@cern.ch>
-
Openpgp:
preference=signencrypt
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1
Hey Tom,
I finally got around to testing this. I could not get it to build on
windows or linux. I'm getting the following compiler error on both 32
and 64 bit windows and linux builds:
E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp: In
member function 'void DEBUG_REPORT::buildVersionInfo(wxString&)':
E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp:292:61:
error: 'OCC_VERSION_COMPLETE' was not declared in this scope
aMsg << indent4 << "opencascade-community-edition: " <<
OCC_VERSION_COMPLETE << eol;
^~~~~~~~~~~~~~~~~~~~
[ 43%] Building CXX object common/CMakeFiles/common.dir/eagle_parser.cpp.obj
E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp:292:61:
note: suggested alternative: 'STG_E_INCOMPLETE'
aMsg << indent4 << "opencascade-community-edition: " <<
OCC_VERSION_COMPLETE << eol;
^~~~~~~~~~~~~~~~~~~~
STG_E_INCOMPLETE
By chance did you build with OCC instead of OCE which is what I am
using? Please fix this when you get a chance, I would like to get this
merged but I need to be able to test.
Why did your remove the GDK_* and GTK_* environment variables from
APP_KICAD ctor? Wont this break the compatibility support we currently
have?
I noticed quite a bit of trailing whitespace in patches 5 and 10 so that
will need to be cleaned up.
Please send me the link to your remote branch for this. It's easier for
me to just pull a branch into my repo than apply a large patch set using
`git am`.
Thanks,
Wayne
On 4/14/2019 6:50 PM, Tomasz Wlostowski wrote:
> Dear all,
>
> The attached patchset introduces a builtin crash reporter for Kicad -
> that is a window that pops up in case of a segmentation fault/other
> serious error, kindly apologizes to the user and lets him/her submit
> (anonymously) a bug report to us. It's loosely based on wxDebugReport,
> with a lot of new code (i.e. stack walker for windows or more meaningful
> report format...).
>
> This is particularly targeted at Windows/OSX users, since getting a
> useful stack trace on these systems is considerably more difficult (at
> least for non-programmers) than on (L)Unixes.
>
> I invite you to test it, in case recent KiCad nightlies have become too
> stable, you can always simulate a crash through 'Help->Simulate Kicad
> Crash'.
>
> Cheers,
> Tom
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References