← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Crash Reporter

 

On 02/05/2019 07:06, Wayne Stambaugh wrote:
> Hey Tom,
> 
> I finally got around to testing this.  I could not get it to build on
> windows or linux.  I'm getting the following compiler error on both 32
> and 64 bit windows and linux builds:
> 
> E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp: In
> member function 'void DEBUG_REPORT::buildVersionInfo(wxString&)':
> E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp:292:61:
> error: 'OCC_VERSION_COMPLETE' was not declared in this scope
>      aMsg << indent4 << "opencascade-community-edition: " <<
> OCC_VERSION_COMPLETE << eol;
> 
> ^~~~~~~~~~~~~~~~~~~~
> [ 43%] Building CXX object common/CMakeFiles/common.dir/eagle_parser.cpp.obj
> E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp:292:61:
> note: suggested alternative: 'STG_E_INCOMPLETE'
>      aMsg << indent4 << "opencascade-community-edition: " <<
> OCC_VERSION_COMPLETE << eol;
> 
> ^~~~~~~~~~~~~~~~~~~~
> 
> STG_E_INCOMPLETE
> 
> By chance did you build with OCC instead of OCE which is what I am
> using?  Please fix this when you get a chance, I would like to get this
> merged but I need to be able to test.
> 
> Why did your remove the GDK_* and GTK_* environment variables from
> APP_KICAD ctor?  Wont this break the compatibility support we currently
> have?
> 
> I noticed quite a bit of trailing whitespace in patches 5 and 10 so that
> will need to be cleaned up.
> 
> Please send me the link to your remote branch for this.  It's easier for
> me to just pull a branch into my repo than apply a large patch set using
> `git am`.

Hi Wayne,

Probably I screwed something up while rebasing the code on top of fresh
master. I'll check/fix the errors in the evening.

Greetings from CO,
Tom


Follow ups

References