← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Replace remaining Boost Mutexes with std::mutex



Thanks for pushing it. I saw that on the todo list along with the auto_ptr
replacement and decided to take a stab at it. I didn't end up doing the
auto_ptr replacement part since when I looked through the code it seems
they are only used in the sch_lib_table files, which I believe would be
part of the overhaul for v6 with the new file formats. Whoever ends up
working with those parts can do the replacements then and that will take
care of all the parts in the C++11 technical todo list.


On Sat, May 4, 2019 at 1:20 AM Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:

> Am 2019-05-03 14:04, schrieb Ian McInerney:
> > This patch series removes the last uses of MUTEX and MUTLOCK from the
> > code base, so now everything is using std::mutex and std::lock_guard
> > instead of the Boost provided classes. I have also removed the
> > ki_mutex.h header file since this is no longer needed (and found an
> > extraneous inclusion in the process).
> >
> > This was made against the master branch. It appears the kicad_curl.cpp
> > file has diverged due to openssl changes between 5.1 and master, which
> > makes this not apply cleanly to 5.1.
> This looks good Ian.  I had been meaning to get around to this but you
> beat me to it!  Nice work.  Thank you for your contribution!
> I don't think we need to push this to 5.1 but it's nice to have in
> master.
> -Seth

Follow ups