← Back to team overview

kicad-developers team mailing list archive

Re: small typos (missing spaces)



On 4/10/19 2:35 AM, Marco Ciampa wrote:
> On Tue, Apr 09, 2019 at 08:58:48PM +0200, Tomasz Wlostowski wrote:
>> On 09/04/2019 18:43, Kerusey Karyu wrote:
>>> Guys
>>>> #: pcbnew/exporters/export_hyperlynx.cpp:190
>>>> m_reporter->Report(
>>>>    _( "File contains pad shapes that are not supported by the"
>>>>       "Hyperlynx exporter (oval, rectangle, circle). They have been"
>>>>       "exported as oval pads." ),
>>> Is there no contradiction here or poor wording?
>>> The first sentence says that oval, rectangular or circular are *not*
>>> supported - as I understand. But finally these are still exported as
>>> ovals, which are... after all, unsupported.
>>> Maybe:
>>> "File contains pad shapes that are not supported by the"
>>> "Hyperlynx exporter. Only oval, rectangle, circle are allowed."
>>> "During export, they will be changed to ovals."
>> My bad, please send me the patch with the wording you prefer. But didn't
>> you notice this message is not (yet) printed anywhere as the m_reporter
>> is always null?
> Here is the patch (thanks Kerusey for the hint) ... check if the meaning
> is right please...

You patch no longer applies cleanly.  Please rebase and resubmit your patch.



Follow ups