kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

John,

If this is not acceptable, would an option that allows the user to turn
this feature on or off be an acceptable solution.  In some use cases, I
can see the value of the this patch.

Henner,

If John, is OK with a user option, would you be OK with making this
behavior user configurable?

Cheers,

Wayne

On 5/2/19 1:24 PM, John Beard wrote:
> I had a quick look at this. I'm not sure expanding all search hits to
> show sub units is the best fix here. It means for the 7400 series that
> you can fit only 3 or 4 search hits in the dialog at default size.
> 
> I think it would be reasonable to expand only as far as the LIBID nodes.
> 
> Cheers,
> 
> John
> 
> On 2 May 2019 17:22:12 BST, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> 
>     Hey Henner,
> 
>     On 5/2/19 12:18 PM, Henner Zeller wrote:
> 
>         On Tue, 30 Apr 2019 at 20:24, Henner Zeller <h.zeller@xxxxxxx>
>         wrote:
> 
> 
>             Hi,
>             so here one digit patch.
> 
>             Problem Symptom: in the schematic symbol chooser, if you
>             search for an
>             exact match of a component with multiple units, it is not
>             selected.
>             For instance, search for
> 
>             74LS00
> 
>             The scored element is in the tree, but you need to manually
>             unfold it
>             (see before.png image). This usually works otherwise (I
>             suspect it has
>             to do with the fact that there are sub-units).
> 
>             The attached change will reliably select the first unit of that
>             particular symbol and fix the problem (after.png image).
> 
>             Now it might be up for debate if the search should actually
>             unfold to
>             the first unit or if the tree unfolding should stop at the
>             74LS00 part
>             - I guess if the latter is wished, something dependent on
>             tree-children needs to be introduced. I leave that up to you.
> 
>             Attached: patch (against 5.1 branch),
> 
> 
>         It also applies cleanly against current head, which has the same
>         problem.
> 
> 
>     I'm on it.  I'm digging through my backlog of patch reviews.  I should
>     get to it today or tomorrow.
> 
>     Cheers,
> 
>     Wayne
>     ------------------------------------------------------------------------
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp
>