kicad-developers team mailing list archive
Mailing list archive
Re: Show grid in eeschema status line
Wayne Stambaugh <stambaughw@xxxxxxxxx>
Tue, 4 Jun 2019 16:46:21 -0400
addr=stambaughw@xxxxxxxxx; keydata= mQGiBEM0hxQRBAC2fNh3YOVLu1d5GZ0SbrTNldGiGnCJPLqzEnqFX9v6jmf33TMt6EmSLkl6 Wtfkoj0nVwKxcYmJkA8DX0QAokBkwNIzhSsBzQvthBLIk/5LnPVVKrEXOcL4mUyH1doKlkaE slgJozNa6Av+oavcvD02o1zJOloBbaHlNlyRt7fKswCgtIFlVjWggVH/15KfWk+Qo5JVPbME AIUBAQyL2OAx0n60AWec2WHnO9buHuG0ibtICgUMkE+2MRmYyKwYRdyVwGoIUemFuOyHp0AJ InX4T+vy2E7vkwODqjtMLfIoRkokW74Fi4nrvjlhOAw/vdq/twLbAmR9MOfPTpR4y7kQy1O2 /n+RkkRvh26vTzfbQmrH7cBJhk6aA/9Uwvu3E4zNJgHVZeS0HyWtmR1eOPPRbnkPgJTToX5O KMKzTJI/FX6kT7cFoCamitHrW3BJP4Dx+cMMsa47EGxqVTdbVJ4LjogsXTXxb+0Fn1u4zBdx x3Cer6O7+hqWy7zvpzeC6nSREjqDKa5CgHtv/GLm5uFPOmsjAsnHj2tlBrQmV2F5bmUgU3Rh bWJhdWdoIDxzdGFtYmF1Z2h3QGdtYWlsLmNvbT6IeAQTEQIAOBYhBOffs6CbblRzBkv33BtR cWlZ+CReBQJbFBS2AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEBtRcWlZ+CReMI8A nRbrLkzp7+c2f0vX7sfg4ICX8LAKAJ9uClo4uJajmZa5zZrL2nKdZlUwIrkCDQRDNIcxEAgA gCru+3/aOC6RCjpvYC72wY+d5SmHphC6yeiV2/mOumyt5MLo/Ps2GznZr11JspqFk5K/Zpvp MMLqqjDZ39+50a2iKRQFJ6NlK+hJWMmj6eJygQrCwYo3Gjc6CqfrqUv+8VSnf/i5sIZmtOVA 4ZjML18MuBvMSsNdVLFJd5HNnYb1iOECpvqdPVh/21LLCEw7MUUGGnHBhCrmk2aJe5hFmcSN g4ldBcXrgMQBwf7aMVoobXBMFDb/IENByXn0llB7Gr2IFMRmNS9/p8s/II1Yl2bTqyX4FSz8 cfn7C9KEz7faZ7wzAcpwHFC/zs3JoAjJ0IEKdNUpIwAlKMzT3CzctwADBQf/cxpG28MKyrqk nNmq/8LQLy+x6FSYXBLjxQz9BiBNYeesDZQ6J5UbL1mjpJzMa5tLZypPYo4bbGyR22hrbyDF K7m6AcVaMIJKl98g4ukMutFfAJyRDaREH5Zl/X1P4u1Z/yaAIy9mKaNbaK1/5djNJ5wCTFen TUgAp9xdc30kGkFDdLJFp5uxDY4P0vaZiZdjUCvDM3Zjv5IzpNOfxVqTUBQNUP/BnnKhkk0p DTD6s3X8S+D0rOtEBQ8K0cwERI/E8EFa8nj0TNw4e2MYGR8wg+SxqJ7z5f0zPY0bO6G9DDFB wYCqzzPWGqdAh9vA5971TAbPERtdFybhkurozp2SfYhJBBgRAgAJBQJDNIcxAhsMAAoJEBtR cWlZ+CResHUAniULLCWiT26ieRTl7N2vS6vBo/DuAJ4m7Ss/gyiW6ybTn1ctDXAUgm2QVQ==
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0
On 6/3/19 12:25 PM, Steven A. Falco wrote:
> On 6/3/19 10:42 AM, Wayne Stambaugh wrote:
>> Hi Steve,
>> Your patch no longer applies cleanly as there has been some serious
>> refactoring and legacy code removal. I think your patch is a good idea
>> but it will need to be fixed. I do have a few comments from your
>> original patch:
>> * Please use `git commit` to commit your code to your local repo and
>> `git format-patch` to create patches to send to the mailing list.
> Thanks for the review, and for your patience as I "learn the ropes" Wayne.
> I've attached a rebased patch using "git format-patch". I generated it both for master and for 5.1, in case you want it in both branches. Personally, I'd like it in both.
>> * There tabs and indentation errors in your original patch.
> I think I've fixed all of those. If I missed any, please let me know.
>> * I don't think you need to make the precision of millimeter grid units
>> 4. 2 should be more than acceptable given that you are using 3 for
>> inches units. You may want to increase this by one for the board
>> editor. The board editor has far greater precision than the schematic
> I chose 4 decimal places because the eeschema grid seems to be in English units internally, even when I switch the UI to metric. I.e., when I switch eeschema to metric, the finest grid in the pull-down menu is shown as "0.0254 mm (1.00 mils)". I don't see a way to set the eeschema grid to a round number of mm. I will be happy to change the display to 2 places if you still want that, but then the status line will show 0.02 mm rather than 0.0254 mm. Please confirm which way you want it.
You are correct so the precision for inch units should be 3 and
millimeter units should be 4.
I think putting the grid in status bar position 4 and the units in
position 5 would look better. Putting the grid after the units feels a
Why did you not add the current grid to the status bar of the board and
footprint editors? I suspect users will ask the same question if/when I
merge this patch. To do so will require some changes because the
precision of the board editor is far greater than the precision of the
schematic editor. Also, the board and footprint editor support
asymmetric grid spacing so overloading DisplayGridMsg() in
PCB_BASE_FRAME would do the trick to handle this.
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp