kicad-developers team mailing list archive

[Nick Østergaard <oe.nick@xxxxxxxxx>]

Hello, I have some comments as well:

I was under the impression that is was only split to multiple options
because it was easier to help isolate issue, i.e. only intended for
developers/packagers to enable/disable some of the options.

The action menu one should probably just be removed and always be
enabled if scripting modules is enabled or something. I don't see why
we need to be able to switch that option off separately by now.

On Thu, 6 Jun 2019 at 18:06, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>
> Hey Ian
>
> On 6/5/19 1:03 PM, Ian McInerney wrote:
> > I was just noticing based on a post on the kicad forums that the CMake
> > script will forcefully enable KICAD_SCRIPTING if either
> > KICAD_SCRIPTING_ACTION_MENUS or KICAD_SCRIPTING_MODULES is turned on.
> > This means to really disable scripting the user has to explicitly force
> > all 3 to off (since they are all on by default). Is there are reason for
> > making those two options take priority over the overall scripting
> > support option instead of having KICAD_SCRIPTING take priority and
> > disable those two when it is disabled? It seems more intuitive if
> > KICAD_SCRIPTING has overall control of the scripting environment, and
> > the others are dependent upon it.
>
> KICAD_SCRIPTIN_MODULES and KICAD_SCRIPTING_ACTION_MENUS depend on
> KICAD_SCRIPTING being built so it has to be enabled.  However,
> KICAD_SCRIPTING does not depend on the other two so it can be enabled by
> itself.
>
> >
> > This hierarchy is not actually mentioned in any of the build docs
> > here http://docs.kicad-pcb.org/doxygen/md_Documentation_development_compiling.html (and
> > the docs seem to be slightly out of date also, since they say
> > KICAD_SCRIPTING_ACTION_MENU defaults to off when it is actually on by
> > default), so if nothing else it would be good to mention it in the build
> > docs so people who really don't want scripting know to disable all 3.
>
> I will update the compiling doc to reflect this.
>
> Wayne
>
> >
> > -Ian
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp