← Back to team overview

kicad-developers team mailing list archive

Re: PATCH pcbnew half-rotate actions and shortcuts

 

Just a note, the hotkey ctrl+shift+R is already assigned to "Differential
Pair Dimensions" by default so this would introduce a duplicate hotkey
conflict. It probably makes sense for this action to be ctrl+shift+R, but
that means that the other needs to be changed.

Also, as a side note to the lead devs, is it still necessary to have the
hotkeys say (Modern Toolset only) in the master branch?

-Ian

On Sat, Jun 8, 2019 at 8:22 AM Andrew Lutsenko <anlutsenko@xxxxxxxxx> wrote:

> Hi all,
>
> I frequently find that I need to rotate a footprint or a few by 45
> degrees. To do that I either have to edit it's properties (works if it's
> just one but slow) or change pcbnew preferences (very slow).
> I thought I'd add a quick shortcut to rotate selected items by half of the
> configured rotation angle and learn a bit of tool related code in the
> process. Please see attached patch for that.
>
> I suspect the way I handled passing double parameter to the action is not
> ideal but it's impossible to have a pointer to constant literal without
> storing it in a variable (to my knowledge). I'm open to suggestions on how
> to clean up that part, maybe move the constants somewhere?
>
> Regards,
> Andrew
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References