kicad-developers team mailing list archive
Mailing list archive
Re: Additional parameters on simulation dialog
Wayne Stambaugh <stambaughw@xxxxxxxxx>
Thu, 27 Jun 2019 15:04:00 -0400
addr=stambaughw@xxxxxxxxx; prefer-encrypt=mutual; keydata= mQGiBEM0hxQRBAC2fNh3YOVLu1d5GZ0SbrTNldGiGnCJPLqzEnqFX9v6jmf33TMt6EmSLkl6 Wtfkoj0nVwKxcYmJkA8DX0QAokBkwNIzhSsBzQvthBLIk/5LnPVVKrEXOcL4mUyH1doKlkaE slgJozNa6Av+oavcvD02o1zJOloBbaHlNlyRt7fKswCgtIFlVjWggVH/15KfWk+Qo5JVPbME AIUBAQyL2OAx0n60AWec2WHnO9buHuG0ibtICgUMkE+2MRmYyKwYRdyVwGoIUemFuOyHp0AJ InX4T+vy2E7vkwODqjtMLfIoRkokW74Fi4nrvjlhOAw/vdq/twLbAmR9MOfPTpR4y7kQy1O2 /n+RkkRvh26vTzfbQmrH7cBJhk6aA/9Uwvu3E4zNJgHVZeS0HyWtmR1eOPPRbnkPgJTToX5O KMKzTJI/FX6kT7cFoCamitHrW3BJP4Dx+cMMsa47EGxqVTdbVJ4LjogsXTXxb+0Fn1u4zBdx x3Cer6O7+hqWy7zvpzeC6nSREjqDKa5CgHtv/GLm5uFPOmsjAsnHj2tlBrQmV2F5bmUgU3Rh bWJhdWdoIDxzdGFtYmF1Z2h3QGdtYWlsLmNvbT6IeAQTEQIAOBYhBOffs6CbblRzBkv33BtR cWlZ+CReBQJbFBS2AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEBtRcWlZ+CReMI8A nRbrLkzp7+c2f0vX7sfg4ICX8LAKAJ9uClo4uJajmZa5zZrL2nKdZlUwIrkCDQRDNIcxEAgA gCru+3/aOC6RCjpvYC72wY+d5SmHphC6yeiV2/mOumyt5MLo/Ps2GznZr11JspqFk5K/Zpvp MMLqqjDZ39+50a2iKRQFJ6NlK+hJWMmj6eJygQrCwYo3Gjc6CqfrqUv+8VSnf/i5sIZmtOVA 4ZjML18MuBvMSsNdVLFJd5HNnYb1iOECpvqdPVh/21LLCEw7MUUGGnHBhCrmk2aJe5hFmcSN g4ldBcXrgMQBwf7aMVoobXBMFDb/IENByXn0llB7Gr2IFMRmNS9/p8s/II1Yl2bTqyX4FSz8 cfn7C9KEz7faZ7wzAcpwHFC/zs3JoAjJ0IEKdNUpIwAlKMzT3CzctwADBQf/cxpG28MKyrqk nNmq/8LQLy+x6FSYXBLjxQz9BiBNYeesDZQ6J5UbL1mjpJzMa5tLZypPYo4bbGyR22hrbyDF K7m6AcVaMIJKl98g4ukMutFfAJyRDaREH5Zl/X1P4u1Z/yaAIy9mKaNbaK1/5djNJ5wCTFen TUgAp9xdc30kGkFDdLJFp5uxDY4P0vaZiZdjUCvDM3Zjv5IzpNOfxVqTUBQNUP/BnnKhkk0p DTD6s3X8S+D0rOtEBQ8K0cwERI/E8EFa8nj0TNw4e2MYGR8wg+SxqJ7z5f0zPY0bO6G9DDFB wYCqzzPWGqdAh9vA5971TAbPERtdFybhkurozp2SfYhJBBgRAgAJBQJDNIcxAhsMAAoJEBtR cWlZ+CResHUAniULLCWiT26ieRTl7N2vS6vBo/DuAJ4m7Ss/gyiW6ybTn1ctDXAUgm2QVQ==
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2
I took a look at your repo and I have a few comments on your changes. I
did not test it so there may be functional issues as well.
Please simplify your logic in
DIALOG_SIM_SETTINGS::TransferDataToWindow(). It's way more complicated
than it needs to be.
Get rid of DIALOG_SIM_SETTINGS::disableCtrlOnCheckboxEvent() and use the
appropriate wxUpdateUIEvent handler to enable and/or disable any
controls. Manually doing this will almost certainly lead to broken
control states. We have done this poorly so many times in the past that
I am not allowing it in new code.
If you want to submit your changes for consideration, you should squash
you changes into a single patch and submit the output of `git
format-patch` to the mailing list.
On 6/21/19 3:00 PM, Sylwester Kocjan wrote:
> I prepared some changes in KiCad simulation dialog. They are about
> additional simulation parameters. According to tutorial, which I've
> found on website, I store them on GitHub repository in branch
> "Sim_InitialConditions_SK" here:
> Could you please have a look and do some review if possible? I'd be
> grateful for feedback if these changes are OK. In future I'd like to
> implement OP analysis using some controls I've added
> Additionally I also prepared polish translation for new strings.
> My aim was to make simulation with arbitrary initial conditions
> possible (additionally I added other options). Right now it is possible
> to enable checkbox UIC on TRAN tab, but there is no possibility to set
> IC to any arbitrary value in element properties. I'm afraid it will
> involve change in .sch format. Please take note that it is also
> possible to define initial conditions for entire nodes instead of
> capacitors or inductors (for example: ".ic v(11)=5 v(4)=-5 v(2)=2.2",
> see ngspice manual, chapter 15.2.2). It is also a challenge.
> So in current state we can use for initial conditions results of .OP
> analysis or default zero.
> From my point of view these are the topics, which should be taken into
> account during review:
> - in simulation code sometimes there is used '\n', sometimes "\r\n".
> Maybe it should be unified? Is there a common definition for newline in
> - I added .option savecurrents: someone added TODO that it doesn't
> work. Maybe should we hide this control?
> - something happened to colours on dialog windows, see attached image.
> I don't know what is it and how to fix it. seems to be unrelated to my
> changes, but maybe I'm wrong? (this is visible on Ubuntu 18.04)
> - some feedback regarding how to add IC field to capacitors, inductors
> or nodes will be very appreciated ;)
> Limitations of my changes:
> - parsing SPICE .options is not implemented (in bool
> DIALOG_SIM_SETTINGS::parseCommand( const wxString& aCommand ))
> Best regards,
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp