kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #41258
Bug 1834718
Hi Wayne-
I can't get Linux to crash for this bug but I do see some memory access
grinding when I follow your steps.
Can you test the attached patch and see if it fixes the issue for you?
Launchpad is down right now, so I can't attach it to the bug report.
This patch should not be committed to the tree. If it fixes the issue,
we can address the root cause but that's a bigger job.
-Seth
From f8241cfecf866145c8686a518508031b767fe716 Mon Sep 17 00:00:00 2001
From: Seth Hillbrand <hillbrand@xxxxxxxxxxx>
Date: Fri, 28 Jun 2019 16:53:04 -0700
Subject: [PATCH] Testing stack size theory
---
include/tool/coroutine.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/tool/coroutine.h b/include/tool/coroutine.h
index 7be173adb..a5d914d88 100644
--- a/include/tool/coroutine.h
+++ b/include/tool/coroutine.h
@@ -298,6 +298,7 @@ private:
size_t stackSize = c_defaultStackSize;
m_stack.reset( new char[stackSize] );
+
// align to 16 bytes
void* sp = (void*)((((ptrdiff_t) m_stack.get()) + stackSize - 0xf) & (~0x0f));
@@ -362,7 +363,7 @@ private:
}
}
- static constexpr int c_defaultStackSize = 2000000; // fixme: make configurable
+ static constexpr int c_defaultStackSize = 4000000; // fixme: make configurable
///< coroutine stack
std::unique_ptr<char[]> m_stack;
--
2.20.1
Follow ups