kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Ian,

I merged your updated patch to the master and 5.1 branches.  Thanks for
updating the patch.

Cheers,

Wayne

On 7/10/19 10:51 AM, Ian McInerney wrote:
> Wayne,
> 
> That's just slightly embarrassing, since I was the author of the
> original code. Here is a corrected version.
> 
> -Ian
> 
> On Wed, Jul 10, 2019 at 3:28 PM Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     Ian,
> 
>     This patch look good except that the enum DXF_Units does not follow the
>     coding policy.  I realize that the previous code was also not compliant
>     but I would prefer we fix coding policy violations when making changes
>     so please change it to DXF_UNITS.  Also, please correct the spelling of
>     DXF_MILIMETERS to DXF_MILLIMETERS.  I will merge this patch once these
>     changes are made.
> 
>     Cheers,
> 
>     Wayne
> 
>     On 6/30/19 4:55 PM, Ian McInerney wrote:
>     > After updating my compiler to Clang 8.0.0, it appears that some new
>     > warnings are appearing. This patch cleans up the warnings in the DXF
>     > plotter (they were related to the units enum and it overshadowing it
>     > some common units). I left these separate since the DXF enum is
>     tied to
>     > the order in the plot window, so it can't use the main units enum.
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     > More help   : https://help.launchpad.net/ListHelp
>     >
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp
>