← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH v2 0/8] MSVC Build


Hi Wayne,

On Tue, Jul 16, 2019 at 06:24:30PM -0400, Wayne Stambaugh wrote:

> I'm ready to push this patch set.  I'm assuming this is the same changes
> as the merge request.  If not please let me know.

The merge request is better:

 - two small fixes for things that happened while rebasing
   - MSVC needs "/utf-8", not "/UTF-8", the latter would be an #undef
   - an unused CMake variable got readded
 - keeps the attribution for Tom's commits.

I've done a rebased branch for 5.1 as well, but will test it first before I
submit that. Since I have a proper day job now, that will be some time.