← Back to team overview

kicad-developers team mailing list archive

Re: [Patch] Return event handled flag from dispatchHotkey


Hi Ian,

I’ve merged your patch.  Thanks!


> On 5 Aug 2019, at 14:03, Ian McInerney <Ian.S.McInerney@xxxxxxxx> wrote:
> This patch modifies the event dispatch in the tool manager to return whether a hotkey has been handled with an action (instead of just returning true if an action with the hotkey exists). This will allow the handler to continue processing the event if the action with the hotkey does not have any active transitions.
> This is something that was discussed on the list before with the hotkey handling (https://lists.launchpad.net/kicad-developers/msg41725.html <https://lists.launchpad.net/kicad-developers/msg41725.html>), and it seemed the discussion said this was a change that should be made (and then fix any fallout from it). I don't think this will break anything, but it will make more keyboard events being passed into the interactive tools.
> -Ian
> <0001-Return-handled-status-for-actions-run-from-hotkeys.patch>_______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp