← Back to team overview

kicad-developers team mailing list archive

Re: [Patch] Move pcbnew layer toolbar icon values to member struct


Hi Ian,

I’ve merged your patch.  Thanks!


> On 5 Aug 2019, at 09:13, Ian McInerney <Ian.S.McInerney@xxxxxxxx> wrote:
> Here is an updated version of this patch that goes with the constexpr color definitions instead of the initialize-on-first-use.
> -Ian
> On Mon, Aug 5, 2019 at 12:20 PM Ian McInerney <Ian.S.McInerney@xxxxxxxx <mailto:Ian.S.McInerney@xxxxxxxx>> wrote:
> This patch moves the static variables in the toolbar icon creation function into a member struct of the PCB_EDIT_FRAME class. These statics had posed some issues on Linux before, and are also not very good for having multiple PCB_EDIT_FRAME instances at one time.
> This patch is dependent upon the prior patch I just sent to fix the initialization of the COLOR4D static variables.
> <0001-pcbnew-Move-layer-toolbar-icon-previous-values-to-st.patch>_______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp