kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #41897
Re: [Patch] Fix some memory leaks
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Thomas Pointhuber <thomas.pointhuber@xxxxxx>
-
Date:
Tue, 13 Aug 2019 19:51:05 +0200
-
Autocrypt:
addr=thomas.pointhuber@xxxxxx; prefer-encrypt=mutual; keydata= mQINBFKxhfoBEADDCVK/vsBRi6BnOVSNa+2+xDQt+rBZt7D7BiTm6vaH/NYh+MFyujViIwIt dducp1y09Bkheqfy1tZVBznAC9L/+scePboOeTRTOMtghp041RXC6K7B4J3RMO0++9XdgDlC KLkNhpyPhb2uKVtGBzZjAPyV9udScv5AnQGrPvE1fIs7CreUPj+sSnRYb0sp5qZRaSpXSmKU NyTFEQtuaR1RXl0Dekj4BfXOr+RBdy8oewvGL64uJYd1ddsJ+uKLURbAZCd4n76g/7y1M+T+ Z0fsO7JT8HPA/4O9FrYHEl6dQTgCos3HsWqqP0xHzW9eR/xTXtNGJ8NSMO11Fla6U27Fb6os XFutSczwkoF3bkhLufodg1y9z+MZ3G5hBidYKRJMxFBLcKqtmcgwfSFI9IP50XH0RY1aOLXJ YsSO/1U+h5LHIYWirLvy6UvWdPD/+cSZgG6JxrHnd/gz0YxzNy8RNo9eGZx34+UTVw6OlKfP CnHvT56Dd9ntRxZ+okKvxSE2/Lc97/xrQj/L1Lgqo6QeHRRmn0V7tAGQR5iYTTVzitjnwGxm St8W4rUJRGdOhpig4r5vy8tZvZ9sJlNkQ2ah1iVTCV1+YBivuKi9EtMCEIoks9AfAPs9iFgl ftmT+5GKq5AA6QuXH9wwlgzJZKQi1UeB4i8RxKnN0De1tINesQARAQABtCxUaG9tYXMgUG9p bnRodWJlciA8dGhvbWFzLnBvaW50aHViZXJAZ214LmF0PokCVAQTAQgAPgIbIwULCQgHAgYV CAkKCwIEFgIDAQIeAQIXgBYhBFeMngIV9HTw3olSRscJ2HTtryVWBQJb8U0eBQkLIPqkAAoJ EMcJ2HTtryVWHhUQAIHo71DWdLPNRnJWAst3plIUqAkomixqKc5utYpPtJLQrjl6bKSk1n/v cGRjGpnWBLtqRnxiwTVdryukCFScqiMM3mHTR+5DL2ftXfNgNPV6TrwShd5YSIIlsmNp++C9 eCtyvoiKH95g7uTbUUbN0NkpOCfl/+94hIjvuNWU0OQ0IBbC7KwPmP4UpH5CB7Pzi8LphPSA P1fRZ3nMgM7+H2jgavWLmTsWrCy53lbodiKII7vQooYoOz7sUntmeNRcbKuBXFyTQEjrQ6UI UoEycHE5zBoGXROnJ5ySYysRl3ZGLrlw//aPT3uwjQunXTTkkBJ5ROwNnWb3HpQNIdp90Icz xdqC06ZNTkMVr+OkNmujhl5f8szATBLzGixmUcDMhkS4Hqmgv3GFt8jT/Q+qVXus7pYl047w qc8msfAQkEBPfnUrYLzNsWeM0zq3P771c36o68ctwasFwMiG2SVkXH48JzZfTjjroP6y4vIi u9CnTG7fEx4fFJBTe1/im1xtMysjCbYY5lwnu0uiGwZMjCaAki80XC+STlLYbRlp0ZjSmUhS o85KRJ/hdIMnUzSXs1BRUM16UymZTbM48w22gBhLKvg5Nkaqib44R9XmFJqCxKVjeNdOQrUE 6XVTgDEB4s5bY+2h3De+gh8fMTTtuiM7I5zufeNNr8M4T9Vn+S3yuQINBFKxhfoBEACrlI5d Uy5YjVGieH3P4G9We26Z33leU8UVl2sL4fxyA3bHC/kPNQRcov3Esd8gQHnSe3BQz5Ei+jNs 1rQxQ1waI66tDePErgJ57HFgwTQs1BotZkqRIiWS2DQ/07kckEF8mD2WrykDP4IbL8J+TOr2 TKwrctdvXxbXSKiYJeg2mC5y9+68lHlyB6l5jTSK3/gV4K/PpnsuGIpbYWPvJGLWkb9coDnD sjL46DwrmEFI5hvvIRreALlN4DBly2Gl1mSPiBV3Z2gwoZHN0hybATE16lw3iQeFCLi2v6ot 2MjWTOh7jwputQTKQ56LAewKENtRSycx4f5OGeXRLv3BMXv/Rl7fWFIvB4xhazzS5idcwyeU jPCsLlwziG2HzN8PbuDBHAIty/usIFUV0Q6+OL0h8IQczqKxFdzg2c5WP2u1Ay0NgWceS1P2 Ck1x4mJH+Hi7UOa8CoidoZ6gqDwm24yL04uU2HlK1qb/aqrNdpfC30dKCPck7OG16CXh5g0q MoJ8owGkDKj5l73CWmvz53jbhO5cPSPeeJJL7kKerG/cZOEtGgyuDGgEHZw2sLI09mYhrXe4 1ioimsRLbjUJzV6G9qmggICPLHxCXUUtPEv0esV/jb6kFBouvXaNUlcgumVt96Msirm1pIxm ebuLWAEtLsamcl0KEX0R87zCPQLl3QARAQABiQI8BBgBAgAmAhsMFiEEV4yeAhX0dPDeiVJG xwnYdO2vJVYFAlvxTSEFCQsg+qcACgkQxwnYdO2vJVZJfQ/+M3gsZFURX0wL2WN9DGfLY/96 Kp1UbD9Ikqt2JY8eZoPjvVyGl5OxUl2TnEdycFeymrGfI5cYZzY1dLg9M6BVLGuTi+TaDcjf 7ZxzoSVJVgTh36f2m1tCsnTgbcCX2kO3TEUecT/kQoABCkAl95sgFZOa1HywSqGVFv78Olx2 r1izacH1AB1z6GWI6D+hdqjIdt1kQu7fDqlmn2Hg7ADYxqJxWas/Nu1tWDjHeZ4tBSFdkGpD Y0qF7w/5KB4rtAPaBXHVKzxxU9CWjUY1DpsS7AEDz1MG6g3Fmgvrx2rD9iockrC58QxzEsbD MlZX5o3BOTt5798Udwn3p4eq2zVEfl7yZJWApbwcZGKwzAq8TGirrPQsR48vKM7lPvENhB0L y0leHiC7haCRpOFfExnhQt+cpI7A9XCBDGSNaUrv6MMRXTFaNz15xEnGsCFUANWLCMiCgunf fsSZg4MAFDTJ05lMtb1pXZrq03wv+6S30pjcaQxO/UEZFmr2t/wL/wqClOF2hsE7GdcEbZfx kmx2tqnbU+kSLSG/6e4KHEVwNg72Ahvmp5DssII/t69VbSzls2C5sUTHeHkOpGN+8gygTjzM ValbSKzBEaJBN9VMkzk2VVDvpo1dTlyqpsMDFtmQfi+tUm4D/bTXvXfNZfNswWMX3yxKFcPW dYhw9pBfZ9Q=
-
In-reply-to:
<20190813164140.GK1959@psi5.com>
-
Openpgp:
preference=signencrypt
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
Indeed,
there is actually a plan to improve this in the future. Personally, I
even wrote down a very rough idea myself:
https://github.com/pointhi/kicad-python/wiki/swig-interface-idea
I was able to compile eeschema with swig binding
(https://github.com/pointhi/kicad-source-mirror/commits/eeschema_swig),
but it looks like I need to wait until the unified coordinate system is
integrated, to start with the real work. Otherwise, sharing a common
library between eeschema and pcbnew could require a unnecessary number
of hacks.
Regards, Thomas
Am 13.08.19 um 18:41 schrieb Simon Richter:
> Hi,
>
> On Tue, Aug 13, 2019 at 05:43:02PM +0200, Ian McInerney wrote:
>
>> Smart pointers would definitely have been nicer to use, but the issue we
>> have with the board objects is they are passed out through SWIG to Python
>> currently, and SWIG doesn't seem to support unique_ptr, so I am not sure
>> how it would react if we gave it a deque of unique_ptrs. Anyone know if
>> that would break anything?
>
> That would break horribly, indeed.
>
> It would probably make sense to have a higher-level interface for
> scripting, and SWIG that instead of exposing the internals, breaking all
> the scripts everytime we improve something. :/
>
> Simon
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Attachment:
signature.asc
Description: OpenPGP digital signature
References