kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Ian,

I merged your patch into the master branch.

Thanks,

Wayne

On 8/22/2019 3:47 PM, Ian McInerney wrote:
> Whoops, that wasn't supposed to be committed. This patch has it removed it.
> 
> -Ian
> 
> On Thu, Aug 22, 2019 at 7:00 PM Jon Evans <jon@xxxxxxxxxxxxx
> <mailto:jon@xxxxxxxxxxxxx>> wrote:
> 
>     Yup, I'm fine with this patch, just trying to answer Ian's question
>     about whether or not there is V6 work planned here.
> 
>     On Thu, Aug 22, 2019 at 11:55 AM Wayne Stambaugh
>     <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>         Jon,
> 
>         Ian's patch resets the layer colors back to the hard coded
>         default layer
>         colors.  I know this isn't a complete solution but it might be handy
>         until you finish the full layer color changes.  Unless this
>         interferes
>         with something you are working on, I'm fine with merging this
>         patch as a
>         short term solution.
> 
>         Ian,
> 
>         You accidentally committed your Doxygen error log file.  I don't
>         think
>         we would want to merge that into the KiCad source.  If Jon is OK
>         with
>         merging this, you please resubmit the patch without your Doxygen
>         error
>         log file.
> 
>         Cheers,
> 
>         Wayne
> 
>         On 8/21/19 5:21 PM, Jon Evans wrote:
>         > Yes, there is V6 work planned for this, I was planning on
>         doing it, but
>         > there are several steps in between (first changing how settings in
>         > general are stored, and then a general refresh of the layers/color
>         > settings GUI)
>         >
>         > On Wed, Aug 21, 2019 at 5:06 PM Ian McInerney
>         <Ian.S.McInerney@xxxxxxxx <mailto:Ian.S.McInerney@xxxxxxxx>
>         > <mailto:Ian.S.McInerney@xxxxxxxx
>         <mailto:Ian.S.McInerney@xxxxxxxx>>> wrote:
>         >
>         >     I noticed today that the layer color selector dialog
>         didn't have a
>         >     way of resetting the color to the KiCad default (I needed
>         to do this
>         >     today). This patch adds the ability for that to be done in
>         Pcbnew
>         >     (for both layers and items).
>         >
>         >     This same thing could be done in Gerbview, but the default
>         colors
>         >     there are not exposed as nicely as in Pcbnew, so it would
>         be more
>         >     convoluted. I wasn't sure if there was already v6 work
>         planned on
>         >     that part, so I have left it alone. If there isn't, then I
>         could go
>         >     back and tidy it up to implement this same defaults system.
>         >
>         >     -Ian
>         >     _______________________________________________
>         >     Mailing list: https://launchpad.net/~kicad-developers
>         >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>         >     Unsubscribe : https://launchpad.net/~kicad-developers
>         >     More help   : https://help.launchpad.net/ListHelp
>         >
>         >
>         > _______________________________________________
>         > Mailing list: https://launchpad.net/~kicad-developers
>         > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         > Unsubscribe : https://launchpad.net/~kicad-developers
>         > More help   : https://help.launchpad.net/ListHelp
>         >
> 
>         _______________________________________________
>         Mailing list: https://launchpad.net/~kicad-developers
>         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         Unsubscribe : https://launchpad.net/~kicad-developers
>         More help   : https://help.launchpad.net/ListHelp
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp
>