← Back to team overview

kicad-developers team mailing list archive

Re: [Patch] Fix wxWidget compatibility issues

 

Wayne,
Yes, it should probably be cherry picked to 5.1.

-Ian

On Thu, Sep 5, 2019 at 2:40 PM Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:

> Ian,
>
> I pushed your patch to the master branch.  Should this patch be cherry
> picked to 5.1?  I suspect it does.  At some point someone will most
> likely want to build 5.1 against wxWidgets 3.1.3 or later.
>
> Cheers,
>
> Wayne
>
> On 8/31/19 10:49 AM, Ian McInerney wrote:
> > wxWidgets have renamed a variable in the wxGrid implementation for their
> > 3.1.3 release, so out implementation needs to have a compatibility check
> > for this now. This patch does that, and also removes an unneeded
> > check/define.
> >
> > -Ian
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

References