kicad-developers team mailing list archive

[Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx>]

Wayne,

Thanks for taking a look.

CMake's COPY_RESOLVED_BUNDLE... and COPY_DIRECTORY don't handle
symlinks correctly, and I ended up having to do a lot of work
modifying CMake stuff, doing a custom Python build, and a few helper
scripts to make sure the proper rpaths stick around.  All of these
shenanigans are related to us having symlinks in our bundles, which
has been a relatively constant battle against Apple and CMake, because
they don't expect it.  I've been in discussion with the CMake folks
for the past few years about it, and they're not really interested in
adding our scenario to their test cases.  (Getting Python included in
the macOS builds as a Framework and a callable executable from both
KiCad.app and the children bundles in a way that can be installed on
other computers was a... monumental effort, to say the least.)

When the symlinks in bundles were made, it was a really great thing
that saved space and made the system really usable on macOS, and I
don't think it's a terrible idea at all--just that the world has
decided it won't support it so we end up having to do a lot of work to
keep it working.

Rather than fix this patch right now, I'd really, really, really like
to get some developer love on
https://bugs.launchpad.net/kicad/+bug/1826649.  I cannot overstate how
much work has been done in order to work around this :)  This is an
impediment to notarized builds, signed builds, and Python 3 support in
the macOS bundles.

Adam

On Tue, Sep 10, 2019 at 8:23 AM Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>
> Adam,
>
> I took a look at this patch set and I have some concerns.  The CMake
> changes seem acceptable but I'm curious as to why you had to add all of
> the python paths in pcbnew.cpp to get Python working under macos.  Does
> Python on macos not look in the install path for library paths like it
> does on other platforms.  If we have to do this to get python to work on
> macos, then at the very least we should at least not hard code the
> python version in the path strings and use a CMake configuration
> variable to generate them.  That way we wont have to modify pcbnew.cpp
> every time we update to a new version of python on macos.  Would one of
> our macos devs please take a look at this and work with Adam so we can
> come up with a solution so we don't have unknown git commit hashes in
> our version strings.
>
> Thanks,
>
> Wayne
>
> On 9/5/19 11:45 AM, Adam Wolf wrote:
> > It would be awesome to have them merged into upstream.  They're all
> > very packaging specific.
> >
> > Here is the current list:
> >
> > * https://github.com/KiCad/kicad-mac-builder/tree/master/kicad-mac-builder/patches/kicad
> >
> > Adam Wolf
> >
> > On Thu, Sep 5, 2019 at 8:19 AM Jeff Young <jeff@xxxxxxxxx> wrote:
> >>
> >> Yeah, it would be -really- nice if we could fix this somehow.  I’ve run into it many times.
> >>
> >> Cheers,
> >> Jeff.
> >>
> >>
> >>> On 5 Sep 2019, at 14:07, Jonatan Liljedahl <lijon@xxxxxxxxxxxx> wrote:
> >>>
> >>> On Thu, Sep 5, 2019 at 1:59 PM Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
> >>>>
> >>>> Does the sha listed in the version info from the runtime app not match?
> >>>
> >>> Unfortunately not. For example (5.1.4-60-ga2950354a)
> >>>
> >>> lijon-mbp:kicad lijon$ git branch
> >>> * 5.1
> >>>  master
> >>> lijon-mbp:kicad lijon$ git log --oneline | grep ga2950354a
> >>> lijon-mbp:kicad lijon$
> >>>
> >>>
> >>> --
> >>> /Jonatan
> >>> http://kymatica.com
> >>>
> >>> _______________________________________________
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp