← Back to team overview

kicad-developers team mailing list archive

Re: [Patch] Clean up file extension handling in Pcbnew graphics plugins



I merged your patch into master and 5.1.



On 9/26/2019 4:20 PM, Ian McInerney wrote:
> After the various fixes for the file extension handling in the recent
> weeks, another small bug was introduced for GTK this time, specifically
> that the extension displayed to the user in the file selector box
> included the full regex that was used to match the extension.
> This patch fixes that issue, but also reorganizes the extension handling
> to clean it up. Specifically it makes the file dialog creation use the
> standard functions for creating the dialog wildcard strings, and creates
> a new common function performs file extension matching (this is then
> referenced by the plugin manager to clean up the code there).
> The 5.1 branch also shows this issue, so it would be good to backport
> this fix to 5.1 as well.
> -Ian
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp