kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #42177
Re: [Patch] Clean up file extension handling in Pcbnew graphics plugins
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Fri, 4 Oct 2019 17:14:57 -0400
-
In-reply-to:
<CACp=VfagRTFeOUXJpjyvfJ2F_Le1dW5mqo0CGCrNQ5HcvCi2ug@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0
Ian,
I merged your patch into master and 5.1.
Thanks,
Wayne
On 9/26/2019 4:20 PM, Ian McInerney wrote:
> After the various fixes for the file extension handling in the recent
> weeks, another small bug was introduced for GTK this time, specifically
> that the extension displayed to the user in the file selector box
> included the full regex that was used to match the extension.
>
> This patch fixes that issue, but also reorganizes the extension handling
> to clean it up. Specifically it makes the file dialog creation use the
> standard functions for creating the dialog wildcard strings, and creates
> a new common function performs file extension matching (this is then
> referenced by the plugin manager to clean up the code there).
>
> The 5.1 branch also shows this issue, so it would be good to backport
> this fix to 5.1 as well.
>
> -Ian
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References