kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Ian,

I'm all for fixing broken hotkeys.  I suspect your assessment is correct
and that fixing it will not be as easy as using the sample code in the
wxWidgets documentation.  I'm guessing we have (unsuccessfully) added
code to try to work around this already.  Any attempt to fix this is
going to require a lot of testing before we can merge it.

Cheers,

Wayne

On 10/4/19 5:49 PM, Ian McInerney wrote:
> I was doing some digging in the hotkey code to try to see what may be
> causing this issue: https://bugs.launchpad.net/kicad/+bug/1840528, and I
> think it may be due to not using the actual unicode character as the
> hotkey we process.
> 
> According to wxWidgets, GetKeyCode()
> <https://docs.wxwidgets.org/3.0/classwx_key_event.html#a3dccc5a254770931e5d8066ef47e7fb0>
> only returns a valid code for ASCII and latin-1 characters but not for
> other alphabets (such as Russian, which is the alphabet the original
> reporter is using). I see that we are doing some processing of the
> unicode key in the current framework, but only on OSX, and it is not
> used as the actual keycode for running the action. Are there any
> foreseeable problems that could be caused by switching the hotkey
> architecture to use the unicode key codes instead of the normal key
> codes? (It isn't as simple as changing out the one call, since we have
> to handle the fact that the GetUnicodeKey() function doesn't return for
> some special keys, hence the sample code in the wxWidgets documentation).
> 
> Thoughts?
> 
> -Ian
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>