← Back to team overview

kicad-developers team mailing list archive

Should gerber files in protel format use same name? (PATCH?)

 

Hi,
sorry, I'm not quite sure with that topic, as I never worked with
protel gerber format before. My PCB manufacturer started to use some
online tool to check gerbers
(https://www.frontline-pcb.com/products/sales/insight-pcb-overview.html)
and now they demand to send them files with protel extensions. But
that tool expect all files with same name. But now if you switch "use
protel extensions" in KiCad, it generate something like :
project_name-F_Cu.gtl
project_name-B_Cu.gbl
If "project_name.gtl" is the proper way, can you please apply my patch?
btw, Altium creates similar to "project_name.gtl"

And another question:
For some reason they demand drill files to be same precision as
gerbers (for example 4:5). Can you confirm that proper Excellon format
should be 3:3 precision? In that case, I would send bug report to
them.
From 1357e1f191043809e0dfc7b00ec2ac7af4a3ec08 Mon Sep 17 00:00:00 2001
From: Alexander <alexandr.shuklin@xxxxxxxxxxxx>
Date: Wed, 16 Oct 2019 08:04:02 +0300
Subject: [PATCH] Use same file name when plot with protel extensions
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------2.23.0"

This is a multi-part message in MIME format.
--------------2.23.0
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit

---
 pcbnew/dialogs/dialog_plot.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)


--------------2.23.0
Content-Type: text/x-patch; name="0001-Use-same-file-name-when-plot-with-protel-extensions.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0001-Use-same-file-name-when-plot-with-protel-extensions.patch"

diff --git a/pcbnew/dialogs/dialog_plot.cpp b/pcbnew/dialogs/dialog_plot.cpp
index 5f1c97fa7..ecedf61f1 100644
--- a/pcbnew/dialogs/dialog_plot.cpp
+++ b/pcbnew/dialogs/dialog_plot.cpp
@@ -834,7 +834,11 @@ void DIALOG_PLOT::Plot( wxCommandEvent& event )
         if( m_plotOpts.GetFormat() == PLOT_FORMAT_GERBER && m_useGerberExtensions->GetValue() )
             file_ext = GetGerberProtelExtension( layer );
 
-        BuildPlotFileName( &fn, outputDir.GetPath(), board->GetLayerName( layer ), file_ext );
+        // Do not use suffix for protel extensions
+        wxString suffix = "";
+        if( !m_plotOpts.GetUseGerberProtelExtensions() )
+            suffix = board->GetLayerName( layer );
+        BuildPlotFileName( &fn, outputDir.GetPath(), suffix, file_ext );
         wxString fullname = fn.GetFullName();
         jobfile_writer.AddGbrFile( layer, fullname );
 

--------------2.23.0--



Follow ups