Thread Previous • Date Previous • Date Next • Thread Next |
Le 06/11/2019 à 23:18, Mikołaj Wielgus a écrit : > Hello, > > I have submitted two patches on Launchpad some time ago. I would like to > ask for feedback. > > Links: > https://bugs.launchpad.net/kicad/+bug/1841144 > https://bugs.launchpad.net/kicad/+bug/1016464 > > Best Regards, > Mikołaj Wielgus Hi Mikołaj, First, thanks for your contribution. I had a look into your patches. I do not seen big problems, but I suggest a few enhancements: - Project manager multiple selection options: When deleting a list of files, a confirmation is asked for each file. Only one confirmation is enough. When deleting a list of files, a instance of the editor is opened for each file. All editors are able to open more than one file, so I suggest only one instance of the editor opening all files. - Pcbnew drill sizes statistics: It display pads with no holes. The filter to select pads: if( pad->GetAttribute() != PAD_ATTRIB_SMD ) is incorrect (other pads can have no hole). the filter must test only the hole size. A minor cosmetic issue: The columns sizes are too small: When sorting a column, the column label is not readable (see X size column in attached files). They are minor issues. Can you fix them. Thanks. -- Jean-Pierre CHARRAS
Attachment:
dlg_incorrect.jpg
Description: JPEG image
Attachment:
dlg_ok.jpg
Description: JPEG image
Thread Previous • Date Previous • Date Next • Thread Next |