kicad-developers team mailing list archive

[Jonatan Liljedahl <lijon@xxxxxxxxxxxx>]

Indeed, it seems that in all cases the actual spice vector used for
the X axis will be "frequency", which as far as I can tell is always
log. Perhaps it would make sense to just replace SPT_LOG_FREQUENCY and
SPT_LIN_FREQUENCY with a single SPT_FREQUENCY enum?

I'm not sure how plotting linear frequency works in ngspice, is this
done with some command that alters the "frequency" vector (which would
then propagate to KiCad), or is it handled in the plot command?

Cheers

On Thu, Nov 7, 2019 at 2:13 AM Ian McInerney <Ian.S.McInerney@xxxxxxxx> wrote:
>
> I would guess that is a mistake. It seems that the intention is to eventually have both linear and log scaling, so they would need to be different. Right now though it looks like log scaling isn't handled differently (a search for SPT_LOG_FREQUENCY returns a TODO comment and an if check that is also for the SPT_LIN_FREQUENCY).
>
> -Ian
>
> On Wed, Nov 6, 2019 at 9:24 PM Jonatan Liljedahl <lijon@xxxxxxxxxxxx> wrote:
>>
>> in sim_types.h:
>>
>> //> Possible plot types
>> enum SIM_PLOT_TYPE {
>>     // Y axis
>>     SPT_VOLTAGE         = 0x01,
>>     SPT_CURRENT         = 0x02,
>>     SPT_AC_PHASE        = 0x04,
>>     SPT_AC_MAG          = 0x08,
>>
>>     // X axis
>>     SPT_TIME            = 0x10,
>>     SPT_LIN_FREQUENCY   = 0x20,
>>     SPT_LOG_FREQUENCY   = 0x20,
>>     SPT_SWEEP           = 0x40
>> };
>>
>> Is it by purpose that the lin/log freq flags have the same value?
>>
>> --
>> /Jonatan
>> http://kymatica.com
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp



-- 
/Jonatan
http://kymatica.com