← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH v3] [NEW] eeschema: Allow hierarchy navigator to stay open

 

Le dim. 10 nov. 2019 à 18:29, jp charras <jp.charras@xxxxxxxxxx> a écrit :
>
> Le 10/11/2019 à 17:33, Franck Jullien a écrit :
> > Le jeu. 7 nov. 2019 à 21:51, <franck.jullien@xxxxxxxxx> a écrit :
> >>
> >> From: Franck Jullien <franck.jullien@xxxxxxxxx>
> >>
> >> User can now decide to keep the hierarchy navigator open while working
> >> on a schematic. This behavior can be configured in
> >> eeschema->preferences->eeschema->Editing options.
> >>
> >> Signed-off-by: Franck Jullien <franck.jullien@xxxxxxxxx>
> >> ---
> >>
> >> v2: fix coding style
> >> v3: fix memory leak after Wayne review
> >
> > I need to work on it again. If the navigator stays open and you add a
> > new page, the hierarchy is not updated.
> > I'll be back with a v4 :)
> >
> > Franck.
>
> Hi Franck,
>
> This is the main problem with not modal dialogs: they have to take in
> account changes made in an other frame, and this is not always easy.
>
> (Here: adding/renaming/deleting a hierarchical sheet)
>
> Remember: your patches must be in a attached file.
> Patch texts inside a mail cannot be used (are broken for patch utilities).

I didn't know patch must be attached. Moving to gitlab will be awsome :)
I'm sending a v4 now. Hopefully this is the last one.

Merci.

Franck.


Follow ups

References