kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #42534
Re: [PATCH v3] [NEW] eeschema: Allow hierarchy navigator to stay open
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Suminski <maciej.suminski@xxxxxxx>
-
Date:
Mon, 11 Nov 2019 14:57:23 +0100
-
Arc-authentication-results:
i=1; mx.microsoft.com 1; spf=pass (sender ip is 188.184.36.46) smtp.rcpttodomain=lists.launchpad.net smtp.mailfrom=cern.ch; dmarc=bestguesspass action=none header.from=cern.ch; dkim=none (message not signed); arc=none
-
Arc-message-signature:
i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZ9yHyyoluo/i2C9erotm1KSpyqL+PlHyjw/DgQgI/0=; b=Pop/6X+Gzvl2yOkil6bf7mskd5qoeTEZXr/aPp/Yf09FRmzpZXKuSaXu/eXYgSKZgs78+FED3mfg7c8e13F9XmvDF/v+Vlak6lNoBP1ne9aN+/G9tDP9tmfxVlWxb+p04jz0Wy89zpAd9T30EOM7TBlo2Jqh+byMA3rpukAwDzy/kLhaWVowBuHgokFPSJ5hJXLboHhPdos7KZISdS1ZQFraEWgMDaM96V1Ekya8+x4iZtRTlOiAF6HE86zDdSz2fMHf9dfvyOMKQB8d5cpi1tmbyhmhQ2HKkqzk/BlHxavkv74zf6OgK33cugRK5/WOMBORXb4TyhAV1RZ3Hgrcsg==
-
Arc-seal:
i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hjitrRSITtBGkhKEC/96Ex+eS1dgQ07vS6upumv/fNa4jkuTD71PkHO2e2T0FC0iicx7KofYBdGc7Xt75OuU1s0KHNbIMXtKehBAtILty67rkOosv/F5mFNeOXdq2Ay0g2XPisICXlU67dz94TdfubNAxT7qVefDyU/+i90QV+rOhUq7bCpCMxIKOPRi3Fg4yrOhQ32wL6VHnRedZciVLx2OAb2+tT6TKr87jeBkobUKz6fd6zIVc7kk67J2zGs4Y7VKr4ad0FjGFmyBK6Z17WuDNRZW1jnb1ObKOoa+ZWsO8i0qsYvQWocABCXk7VLw3kG2sjRheOkRn3PMbiCQcA==
-
Authentication-results:
spf=pass (sender IP is 188.184.36.46) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
Autocrypt:
addr=maciej.suminski@xxxxxxx; keydata= mQENBFKfmAwBCAC9tak+4mDO1WiNnAwegusPBMEdl+sV35XeaU4PGSt33mPSlXB2klamg4ih QUykvuWqNEg2KyTvCSKNfnHTpzeeFegEsIwWFdhbIc4uUAD6CHl4+uGTXQiMh1+IJkgLmwuD RCEx9mSKbdzzTKz05w+fzzT3mNfko8NICWlcmhFgo2RXnQRTqFg7CNNBpx4kr4+AWIvb+Rha AVMLVJj1s05+STGyFucu6sZmTmOC53ZtkV8HchJeGuQL0LPkjvX0VKGE3gkvuP4iLBcgFtNC Kcu/L6FmWd24m2IhWaHXoWLBiVFw7gGzUdB7gSAiNO1+SoWX+99rbud7RvqV49vOgoqbABEB AAG0KU1hY2llaiBTdW1pbnNraSA8bWFjaWVqLnN1bWluc2tpQGNlcm4uY2g+iQE5BBMBAgAj BQJSn5gMAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQFHAa7WGlsnU/JQf5AYW0 oFH+jOykZvlRkRZMoqw1vZGOHeRPK92vbjeiau/hALYX1FBvZMx+JMmVHN7DkRIY7bVoiJ6N n4Byn//BSd9F9eXjAphYVuBg2Xe5wp3/l9/z2Iw8KeLpfKAtfIybgpycvTuUxFIxm9mtpPt+ AoNFKBDhfLcpZLJTW7AwwpnzP+GDdjszjnW6rMt8Aq55liR+y/TZfz/tTEDcUcSPLlJBTmda TmkO5aPxPmeCeDMOT3YEd+bK57V5b7RgtqTdIT6CW7tjQKBPJbIGa8PQ0tUfz0yCBEPWghnY w+B/2JeArrRXDui78cGgTDy1ocQNAm3havk2WO2qykxziY6OwbkBDQRSn5gMAQgAxw+MRllT IPNnCeOAbRgX1KRzo7+7WpSIbmhrBzLY0O1SyIa7U05E6+4jDHDfDpSLqc61an1+M69e6l9Z E3ve3hymtj5ucXZQnveQ5klD6z5FBC/04of/YyrS+h6iRSM0nOmu1JOIqM0S2OzwsKRsS86r jCtRE5OxoBDCIB4xNPitezs4uvLoVfO3mVYUhiPRZMtTCInEi+tlM+AmaPjRkPAfhd0wsOjk oxkuJWEnZ8U8oHpeL0uqANZgLlIiT5yJMWsyyqlK01hdFbuIydIFFiyXJw1HDTXWX+tMxJrX VEvQJZALof9RU/jntqGltnQXArUgPMSGGu1f+7AH/CuMyQARAQABiQEfBBgBAgAJBQJSn5gM AhsMAAoJEBRwGu1hpbJ1maAH/RZPbvXaNIOouHZlnlkq/WORHxjkKfve+AbE62Ed8yFIwlAj tyZGKeEG9hDJl6f9BxDv+9qunTfWfXQuHxNIpdXstkxQIx4m043Kx3h7VdEmg53ybeGNgpvz BYk5HdgCH3yP6UbGNiel6xZOywmvpru3pEKNg4mJhzxm9JCG+djrvbRh+BZNOkDBgaSiCAuJ q6Ffo9Qk/qfl6Uim9G7GKSS4930ZQ2GoVObe+jXixOhWXFSDhGKX5meABmELJ9XTcW3Pp6XC 0KXOE2p0EHQPmFvXdU6OePI72jTgRzPJXRXbPkL0/NUfbZfxS/xnAG8jmODc2ufbtrvE2jPu INX35u4=
-
In-reply-to:
<CAJfOKBzCVfeaX4w4M2gUa6UOp2Sdhm4bwW4jD_yh8W=sz8xXow@mail.gmail.com>
-
Openpgp:
preference=signencrypt
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0
Hi Franck,
Please remember to add changelog tags [1] when sending patch v4. Thanks!
Cheers,
Orson
1. http://docs.kicad-pcb.org/doxygen/commit_messages.html
On 11/10/19 7:36 PM, Franck Jullien wrote:
> Le dim. 10 nov. 2019 à 18:29, jp charras <jp.charras@xxxxxxxxxx> a écrit :
>>
>> Le 10/11/2019 à 17:33, Franck Jullien a écrit :
>>> Le jeu. 7 nov. 2019 à 21:51, <franck.jullien@xxxxxxxxx> a écrit :
>>>>
>>>> From: Franck Jullien <franck.jullien@xxxxxxxxx>
>>>>
>>>> User can now decide to keep the hierarchy navigator open while working
>>>> on a schematic. This behavior can be configured in
>>>> eeschema->preferences->eeschema->Editing options.
>>>>
>>>> Signed-off-by: Franck Jullien <franck.jullien@xxxxxxxxx>
>>>> ---
>>>>
>>>> v2: fix coding style
>>>> v3: fix memory leak after Wayne review
>>>
>>> I need to work on it again. If the navigator stays open and you add a
>>> new page, the hierarchy is not updated.
>>> I'll be back with a v4 :)
>>>
>>> Franck.
>>
>> Hi Franck,
>>
>> This is the main problem with not modal dialogs: they have to take in
>> account changes made in an other frame, and this is not always easy.
>>
>> (Here: adding/renaming/deleting a hierarchical sheet)
>>
>> Remember: your patches must be in a attached file.
>> Patch texts inside a mail cannot be used (are broken for patch utilities).
>
> I didn't know patch must be attached. Moving to gitlab will be awsome :)
> I'm sending a v4 now. Hopefully this is the last one.
>
> Merci.
>
> Franck.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References
