kicad-developers team mailing list archive

[Jonatan Liljedahl <lijon@xxxxxxxxxxxx>]

Ok, I'll look into making it configurable. However, I find the current
default appearance hard to use, so maybe one could consider changing
the defaults in that case?

Not only does it make the text easily legible, but also the whole
symbol less cluttered when selected. You can still select individual
text fields as expected, but only the symbol and its pins are drawn as
selected when the whole component is selected.

These are the parts I've disabled for drawing of the selection shadow:
- pin labels/names
- component fields
- subsheet pins
- subsheet title/file

Additionally, I changed the shadow width algo constants as follows, to
avoid the feeling of the selection shadow changing size drastically as
you zoom:

float SCH_PAINTER::getShadowWidth()
{
    const MATRIX3x3D& matrix = m_gal->GetScreenWorldMatrix();

    // For best visuals the selection width must be a cross between
the zoom level and the
    // default line width.
    return (float) ( ( fabs( matrix.GetScale().x * 1.0 ) +
GetDefaultLineThickness() ) * 4.0 );
}

So now the question is at what granularity all this should be
configurable? Perhaps:

- selection draw child-items: bool
- selection thickness: float
- selection color (already there)

Cheers

On Wed, Nov 20, 2019 at 3:29 PM Ian McInerney <Ian.S.McInerney@xxxxxxxx> wrote:
>
> I'm on the fence about the text highlighting, on the one hand not doing it does make it so the text is still easily legible when selected, but on the other it can be nice to show that it is part of the selected symbol. I think this would definitely be a case where making it a configurable option would allow people to experiment and see what they prefer.
>
> -Ian
>
> On Wed, Nov 20, 2019 at 2:18 PM Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:
>>
>> On 2019-11-20 05:48, Jonatan Liljedahl wrote:
>> > Hi,
>> >
>> > I'm tweaking the appearance of the new selection, what do you think?
>> > Except a change of color, transparency and width, it also skips
>> > drawing the fields and pin labels of components. I think it gives a
>> > much cleaner look with less clutter.
>>
>> This will always be a matter of opinion.  Right now the color is
>> configurable.  If you'd like to add additional configurable parameters
>> to the selection, you should place them in the Eeschema preferences and
>> allow the user to choose them.  Then post the patch for review.
>>
>> Otherwise, we'll end up bike shedding on this which would be nice to
>> avoid.
>>
>> Best-
>> Seth
>>
>>
>> Seth Hillbrand
>> KiCad Services Corporation
>> https://www.kipro-pcb.com
>> +1 530 302 5483 | +1 212 603 9372
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



-- 
/Jonatan
http://kymatica.com