← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Eeschema: simulator: use dotted traces for current and phase.

 

Also this message didn't reach the list:

On Fri, Nov 22, 2019 at 12:14 AM Kymatica <j.r.liljedahl@xxxxxxxxx> wrote:
>
> Hi,
> With quick and easy I wasn’t actually referring to the coding involved, but to the user experience: when I fire up the simulator I (as a user) just want to see the results and look at the plots, with as little confusion as possible regarding which trace is which, or which trace belongs to which scale. I don’t want to configure anything. But perhaps I missunderstood, and that the proposal wasn’t to have style config per trace/signal but per trace type? (Volt, Current, Mag, Phase) Because traces are volatile, you add and remove them many times depending on what you want to see.
>
> /Jonatan
>
> > 21 nov. 2019 kl. 21:55 skrev Wayne Stambaugh <stambaughw@xxxxxxxxx>:
> >
> > On 11/21/19 2:36 PM, Kymatica wrote:
> >> The idea here was to simply use a different visual style for the traces
> >> that are plotted for the secondary y axis, to make it easy to see which
> >> scale the trace belongs to without having to look it up in the signals list.
> >>
> >> Per trace configuration could be nice, at least if preparing images for
> >> presentation. But for everyday simulation work I’d just want it quick
> >> and easy.
> >
> > I understand the temptation to do the quick and easy hack.  We have all
> > done it.  From a project maintenance perspective, allowing developers to
> > merge their personal quick hacks quickly makes a mess of the KiCad code
> > base.  This is why I would prefer that we carefully consider what trace
> > drawing options we want to support so we can design a solution that
> > works over the long term.
> >
> >>
> >> /Jonatan
> >>
> >>>> 21 nov. 2019 kl. 18:34 skrev Ian McInerney <Ian.S.McInerney@xxxxxxxx>:
> >>>
> >>> 
> >>> This is probably introducing major feature creep, but it would be nice
> >>> to develop a dialog that allows setting the per-trace characteristics
> >>> (such as color, line type, line width, etc) that this could go in.
> >>> Where we put the accessors to it, I am not sure (it would be great if
> >>> we could link it with the legend fields). Then we can add in more
> >>> configuration options there as we implement them.
> >>>
> >>> -Ian
> >>>
> >>> On Thu, Nov 21, 2019 at 5:26 PM Wayne Stambaugh <stambaughw@xxxxxxxxx
> >>> <mailto:stambaughw@xxxxxxxxx>> wrote:
> >>>
> >>>    Hi Jonatan,
> >>>
> >>>    I just tested this and it seems to work as expected although I'm
> >>>    thinking it might be a good idea to make this a configuration option
> >>>    rather than the only behavior.  Users might not find this desirable.
> >>>    Anyone else have any thoughts on this?  For future reference, when you
> >>>    are going to make behavioral changes to KiCad, please ping the dev
> >>>    mailing list first for feedback.  I would have made the option
> >>>    suggestion before you began coding.
> >>>
> >>>    Cheers,
> >>>
> >>>    Wayne
> >>>
> >>>    On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
> >>>> This patch makes it easier to visually keep apart traces for current
> >>>> vs voltage and phase vs magnitude, by using dotted line style for
> >>>> current and phase traces.
> >>>>
> >>>> To get the dotted style drawn correctly, I had to switch from
> >>>    drawing
> >>>> each trace line segment individually to creating an array and then
> >>>> using DrawLines() on it, so that the whole trace is one continuous
> >>>> line.
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>> More help   : https://help.launchpad.net/ListHelp
> >>>>
> >>>
> >>>    _______________________________________________
> >>>    Mailing list: https://launchpad.net/~kicad-developers
> >>>    Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >>>    Unsubscribe : https://launchpad.net/~kicad-developers
> >>>    More help   : https://help.launchpad.net/ListHelp
> >>>
> >>> _______________________________________________
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp



-- 
/Jonatan
http://kymatica.com


References