← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Eeschema: simulator: use dotted traces for current and phase.

 

This would be a great long term solution.  You could also store it in
the project file since it is project specific if you don't want to go
through the effort of designing a new s-expression file format.

On 11/21/19 6:45 PM, Ian McInerney wrote:
> I think it would be good to define a new S-expression config file that
> can be used to store the plot configurations of the simulator. This file
> should just contain the plot information, such as lines displayed, their
> style/color, axis configurations, colors, etc. (and maybe analysis
> parameters, I haven't thought about that part yet). This would allow us
> to add the functionality to open/save plot styles (similar to how a
> Modelsim .do file can be used to save/configure the waveform display,
> but ours won't be a script).
> 
> -Ian
> 
> On Thu, 21 Nov 2019, 22:11 Jon Evans, <jon@xxxxxxxxxxxxx
> <mailto:jon@xxxxxxxxxxxxx>> wrote:
> 
>     I can add the simulator to the scope of effort to do the whole
>     settings files upgrade for 6.0
> 
>     On Thu, Nov 21, 2019 at 5:06 PM Wayne Stambaugh
>     <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
> 
>         On 11/21/19 1:15 PM, Kymatica wrote:
>         > Sure, I can make it configurable. Where should this setting be
>         available? In the main preferences? (Perhaps a new Simulator
>         section there?)
> 
>         I would think the simulator will over time have enough user (not
>         simulation control) configuration settings that it would have
>         it's own
>         preferences dialog and that the settings would be saved in a
>         separate
>         configuration file.  I think at the moment the config settings
>         are saved
>         in the eeschema config file.
> 
>         >
>         > /Jonatan
>         >
>         >> 21 nov. 2019 kl. 18:26 skrev Wayne Stambaugh
>         <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>:
>         >>
>         >> Hi Jonatan,
>         >>
>         >> I just tested this and it seems to work as expected although I'm
>         >> thinking it might be a good idea to make this a configuration
>         option
>         >> rather than the only behavior.  Users might not find this
>         desirable.
>         >> Anyone else have any thoughts on this?  For future reference,
>         when you
>         >> are going to make behavioral changes to KiCad, please ping
>         the dev
>         >> mailing list first for feedback.  I would have made the option
>         >> suggestion before you began coding.
>         >>
>         >> Cheers,
>         >>
>         >> Wayne
>         >>
>         >>> On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
>         >>> This patch makes it easier to visually keep apart traces for
>         current
>         >>> vs voltage and phase vs magnitude, by using dotted line
>         style for
>         >>> current and phase traces.
>         >>>
>         >>> To get the dotted style drawn correctly, I had to switch
>         from drawing
>         >>> each trace line segment individually to creating an array
>         and then
>         >>> using DrawLines() on it, so that the whole trace is one
>         continuous
>         >>> line.
>         >>>
>         >>>
>         >>> _______________________________________________
>         >>> Mailing list: https://launchpad.net/~kicad-developers
>         >>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         >>> Unsubscribe : https://launchpad.net/~kicad-developers
>         >>> More help   : https://help.launchpad.net/ListHelp
>         >>>
>         >>
>         >> _______________________________________________
>         >> Mailing list: https://launchpad.net/~kicad-developers
>         >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         >> Unsubscribe : https://launchpad.net/~kicad-developers
>         >> More help   : https://help.launchpad.net/ListHelp
> 
>         _______________________________________________
>         Mailing list: https://launchpad.net/~kicad-developers
>         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         Unsubscribe : https://launchpad.net/~kicad-developers
>         More help   : https://help.launchpad.net/ListHelp
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References