kicad-developers team mailing list archive

[Jonatan Liljedahl <lijon@xxxxxxxxxxxx>]

Thanks Seth,

I'm on Mac only (my linux box hasn't been powered on since 5 years or so).
The code I touched should not look different depending on platform. I guess
any difference would rather be in how colors are presented (considering the
#ifdef MAC around default selection-highlight color), but even in that case
I strongly suspect this is rather about the monitor rather than operating
system!

Cheers

On Fri, Nov 22, 2019 at 6:25 PM Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:

> On 11/21/19 8:01 AM, Jonatan Liljedahl wrote:
>
> Hi,
>
> Here comes two patches regarding the selection appearance.
>
> Patch #1: Adds three new options in the settings dialog:
>
> - Draw selected text items as box
> Instead of drawing a stroked shadow behind the text, a rounded
> rectangle is drawn according to the text boundary box.
>
> - Draw selected child items
> When disabled, only the main selected item is drawn with the selection
> shadow, not the various fields and pin names etc. Default is enabled
> (current behaviour)
>
> - Fill selected shapes
> Any selected shapes has their selection shadow filled, instead of just
> drawing along the lines.
>
> See attached screenshots for a demonstration of some various
> combinations of these settings.
>
> Patch #2: Tweaks the amount of zoom-level impact on the selection
> shadow thickness, to get a more coherent look while zooming. You need
> to try this in action to know if it's good (I think it is).
>
> Cheers
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
> Hi Jonatan-
>
> Thanks for this patch.  I'll give this a test run this weekend.  I know
> that the Mac display of highlight was always a bit different than Linux, so
> it would be good if one of our Mac devs also tested for issues.
>
> Best-
> Seth
>
> --
> KiCad Services Corporation [image: KiCad Services Corporation Logo]
> Seth Hillbrand
> *Lead Developer*
> +1-530-302-5483‬ <+12126039372>
> Davis, CA
> www.kipro-pcb.com    info@xxxxxxxxxxxxx
> https://twitter.com/KiProEDA <https://twitter.com/KiProEDA>
> https://www.linkedin.com/company/kicad
> <https://www.linkedin.com/company/kicad>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


-- 
/Jonatan
http://kymatica.com