kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #43307
Re: Rebase the tree?
-
To:
Jeff Young <jeff@xxxxxxxxx>
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Mon, 20 Jan 2020 18:43:17 -0500
-
Autocrypt:
addr=stambaughw@xxxxxxxxx; prefer-encrypt=mutual; keydata= mQGiBEM0hxQRBAC2fNh3YOVLu1d5GZ0SbrTNldGiGnCJPLqzEnqFX9v6jmf33TMt6EmSLkl6 Wtfkoj0nVwKxcYmJkA8DX0QAokBkwNIzhSsBzQvthBLIk/5LnPVVKrEXOcL4mUyH1doKlkaE slgJozNa6Av+oavcvD02o1zJOloBbaHlNlyRt7fKswCgtIFlVjWggVH/15KfWk+Qo5JVPbME AIUBAQyL2OAx0n60AWec2WHnO9buHuG0ibtICgUMkE+2MRmYyKwYRdyVwGoIUemFuOyHp0AJ InX4T+vy2E7vkwODqjtMLfIoRkokW74Fi4nrvjlhOAw/vdq/twLbAmR9MOfPTpR4y7kQy1O2 /n+RkkRvh26vTzfbQmrH7cBJhk6aA/9Uwvu3E4zNJgHVZeS0HyWtmR1eOPPRbnkPgJTToX5O KMKzTJI/FX6kT7cFoCamitHrW3BJP4Dx+cMMsa47EGxqVTdbVJ4LjogsXTXxb+0Fn1u4zBdx x3Cer6O7+hqWy7zvpzeC6nSREjqDKa5CgHtv/GLm5uFPOmsjAsnHj2tlBrQmV2F5bmUgU3Rh bWJhdWdoIDxzdGFtYmF1Z2h3QGdtYWlsLmNvbT6IeAQTEQIAOBYhBOffs6CbblRzBkv33BtR cWlZ+CReBQJbFBS2AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEBtRcWlZ+CReMI8A nRbrLkzp7+c2f0vX7sfg4ICX8LAKAJ9uClo4uJajmZa5zZrL2nKdZlUwIrkCDQRDNIcxEAgA gCru+3/aOC6RCjpvYC72wY+d5SmHphC6yeiV2/mOumyt5MLo/Ps2GznZr11JspqFk5K/Zpvp MMLqqjDZ39+50a2iKRQFJ6NlK+hJWMmj6eJygQrCwYo3Gjc6CqfrqUv+8VSnf/i5sIZmtOVA 4ZjML18MuBvMSsNdVLFJd5HNnYb1iOECpvqdPVh/21LLCEw7MUUGGnHBhCrmk2aJe5hFmcSN g4ldBcXrgMQBwf7aMVoobXBMFDb/IENByXn0llB7Gr2IFMRmNS9/p8s/II1Yl2bTqyX4FSz8 cfn7C9KEz7faZ7wzAcpwHFC/zs3JoAjJ0IEKdNUpIwAlKMzT3CzctwADBQf/cxpG28MKyrqk nNmq/8LQLy+x6FSYXBLjxQz9BiBNYeesDZQ6J5UbL1mjpJzMa5tLZypPYo4bbGyR22hrbyDF K7m6AcVaMIJKl98g4ukMutFfAJyRDaREH5Zl/X1P4u1Z/yaAIy9mKaNbaK1/5djNJ5wCTFen TUgAp9xdc30kGkFDdLJFp5uxDY4P0vaZiZdjUCvDM3Zjv5IzpNOfxVqTUBQNUP/BnnKhkk0p DTD6s3X8S+D0rOtEBQ8K0cwERI/E8EFa8nj0TNw4e2MYGR8wg+SxqJ7z5f0zPY0bO6G9DDFB wYCqzzPWGqdAh9vA5971TAbPERtdFybhkurozp2SfYhJBBgRAgAJBQJDNIcxAhsMAAoJEBtR cWlZ+CResHUAniULLCWiT26ieRTl7N2vS6vBo/DuAJ4m7Ss/gyiW6ybTn1ctDXAUgm2QVQ==
-
Cc:
KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
In-reply-to:
<97F3E784-B1E9-49DF-B2DA-7315EB858AD4@rokeby.ie>
-
Openpgp:
preference=signencrypt
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0
No problem. Hopefully it wont cause too many issues for other devs who
have to rebase any local changes.
Cheers,
Wayne
On 1/20/20 6:15 PM, Jeff Young wrote:
> Thanks, Wayne!
>
> Sorry for causing such a mess.
>
> Cheers,
> Jeff.
>
>
>> On 20 Jan 2020, at 22:32, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>
>> I found it. I had to create a new protection for the master branch. I
>> pushed the changes and enabled the GitLab protection for the master
>> branch so we should be good to resume normal development. Thank you for
>> the help and patience to work through this.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 1/20/20 5:27 PM, Nick Østergaard wrote:
>>> It should be there, I am sure you are just confused by the gitlab webui.
>>>
>>> It should be something along the lines of:
>>> Settings -> Repository -> Protected branches, click expand. Set the
>>> proper settings in the "Protect a branch" section.
>>>
>>> On Mon, 20 Jan 2020 at 23:26, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>>>
>>>> Well this is a kick in the teeth. I just unprotected it and I don't see
>>>> an option to re-enable the protection after I force the changes.
>>>>
>>>> On 1/20/20 5:18 PM, Nick Østergaard wrote:
>>>>> There is a "protected branches" section in the settings of the repo.
>>>>>
>>>>> On Mon, 20 Jan 2020 at 23:18, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
>>>>>>
>>>>>> You probably need to disable the option to disable force pushing on the repo.
>>>>>>
>>>>>> On Mon, 20 Jan 2020 at 23:20, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>>>>>>
>>>>>>> GitLab rejected the forced push using this method. Anyone else have any
>>>>>>> ideas. Until we get this resolved, please do not push any commits to
>>>>>>> the master branch.
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Wayne
>>>>>>>
>>>>>>> On 1/20/20 5:13 PM, Wayne Stambaugh wrote:
>>>>>>>> Please do not push anything to the master branch or perform any merge
>>>>>>>> requests until I push the rebase the master branch to prevent any commit
>>>>>>>> losses because forcing a push will wipe out any changes. I ran the git
>>>>>>>> command suggested by Simon and it seems to have the desired results but
>>>>>>>> I have no idea how this is going to play out so I'm making a backup
>>>>>>>> clone of master just in case things go sideways. I'll ping everyone
>>>>>>>> once I have pushed the rebase. Thank you for your cooperation and I
>>>>>>>> apologize for whatever pain and agony this causes. Hopefully we will
>>>>>>>> never make this mistake again.
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>>
>>>>>>>> Wayne
>>>>>>>>
>>>>>>>> On 1/18/20 7:29 AM, Simon Richter wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> On 17.01.20 19:14, Simon Richter wrote:
>>>>>>>>>
>>>>>>>>>> 1. "git rebase -i origin/master"
>>>>>>>>>> 2. in the editor, if they are present, remove the lines
>>>>>>>>>>
>>>>>>>>>> pick ea31730b4 Handle error returns from lstat.
>>>>>>>>>> pick e83420f19 Remove file accidentally commited in ea31730b4
>>>>>>>>>> pick e27e6ee16 Also catch null dereference in case wxASSERT was skipped.
>>>>>>>>>> pick e1925b89c Remove file accidentally added in e27e6ee1
>>>>>>>>>>
>>>>>>>>>> 3. save and exit
>>>>>>>>>
>>>>>>>>> Even less interactive:
>>>>>>>>>
>>>>>>>>> git filter-branch \
>>>>>>>>> --prune-empty \
>>>>>>>>> --index-filter \
>>>>>>>>> 'git rm --cached --ignore-unmatch common/libcommon.a.*' \
>>>>>>>>> 9df2cfb32..HEAD
>>>>>>>>>
>>>>>>>>> This rewrites the current branch to a state where the files were never
>>>>>>>>> added, and removes the now-empty correction commits. The SHA1 sums in
>>>>>>>>> the new branch are different, but as the commit contents are identical,
>>>>>>>>> rebasing feature branches then goes smoothly even from the gitlab GUI.
>>>>>>>>>
>>>>>>>>> If you rebased a branch containing the offending commits on top of a
>>>>>>>>> cleaned one, this generates four commits adding and removing the files
>>>>>>>>> with no further changes, and the filter-branch commit above then reduces
>>>>>>>>> these to no-ops and removes the commits.
>>>>>>>>>
>>>>>>>>> A simple test in gitlab *merge request is descended from e1925b89c"
>>>>>>>>> could identify merge requests that would need to be rewritten.
>>>>>>>>>
>>>>>>>>> Simon
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>>>> More help : https://help.launchpad.net/ListHelp
>>>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>> More help : https://help.launchpad.net/ListHelp
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References
-
Rebase the tree?
From: Simon Richter, 2020-01-17
-
Re: Rebase the tree?
From: Seth Hillbrand, 2020-01-17
-
Re: Rebase the tree?
From: Simon Richter, 2020-01-17
-
Re: Rebase the tree?
From: Jon Evans, 2020-01-17
-
Re: Rebase the tree?
From: Ian McInerney, 2020-01-17
-
Re: Rebase the tree?
From: Nick Østergaard, 2020-01-17
-
Re: Rebase the tree?
From: Ian McInerney, 2020-01-17
-
Re: Rebase the tree?
From: Simon Richter, 2020-01-17
-
Re: Rebase the tree?
From: Simon Richter, 2020-01-18
-
Re: Rebase the tree?
From: Wayne Stambaugh, 2020-01-20
-
Re: Rebase the tree?
From: Wayne Stambaugh, 2020-01-20
-
Re: Rebase the tree?
From: Nick Østergaard, 2020-01-20
-
Re: Rebase the tree?
From: Nick Østergaard, 2020-01-20
-
Re: Rebase the tree?
From: Wayne Stambaugh, 2020-01-20
-
Re: Rebase the tree?
From: Nick Østergaard, 2020-01-20
-
Re: Rebase the tree?
From: Wayne Stambaugh, 2020-01-20
-
Re: Rebase the tree?
From: Jeff Young, 2020-01-20